Repository navigation
Detach CLI credentials atomically before captured account revocation - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI logout previously cleared only its local file. It now captures the latest credentials belonging to the initiating session and clears local authentication in one short file transaction before any network request. Its dedicated Core logout request cannot renew credentials, follow redirects, borrow cookies/netrc/session Basic auth or write into a replacement login. An explicit access rejection may use the captured refresh as revocation-only proof; ambiguous network/server errors are not retried. Organisation API keys are only removed locally.
The command documents account-wide Core sign-out and reports separately when server revocation cannot be confirmed. The paired backend session-authority update in dataplicity-prelude PR3608 is required, including the consumed-refresh revocation-only contract.
Validation: full isolated local suite passes 310 tests and 74 subtests; configured coverage passes at 100% of 1,584 statements. Includes actual loopback HTTP access-to-refresh fallback, Set-Cookie/netrc exclusion, pre-I/O local clearing, identical-byte replacement ownership, concurrent rotation and late-response preservation. Normal cross-platform CI is required before merge.
Private qualification only, targeting codex/native-pkce-login. No main merge, public installer/feed/package release or signing-policy bypass. Matching installed-client/backend staging qualification remains open.