Repository navigation
Conversation
) * Separate CLI API recipients and publisher authentication lifecycle * Bind CLI operations and atomic credential writes to their initiating session * Use Typer error handling without an undeclared Click dependency * Move macOS package verification off retired runner images * Keep release byte-preservation checks strict around the reviewed runner change --------- Co-authored-by: Elliot Mackenzie <emackenzie@Elliots-MacBook-Pro.local>
Co-authored-by: Elliot Mackenzie <emackenzie@Elliots-MacBook-Pro.local>
* Make account-wide CLI logout explicit * Normalize coloured help output in logout contract test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser and manual CLI SSO callbacks currently accept access/refresh tokens. Replace them with a one-use authorization code and client-generated state, bound to an S256 verifier retained only by the running CLI. Exchange at the stored HTTPS identity origin through an anonymous API client, so an existing account's access or refresh credentials cannot authorize or influence another account's login.
The listener binds a random private loopback path, checks Host and state, rejects token payloads/unknown fields/duplicates/replay, and finishes on a clean URL. Manual SSO accepts only the pending callback's code/state proof and hides pasted material. A changed API origin or failed/malformed exchange preserves the existing saved credentials. Browser password/MFA and SAML keep their existing account policies.
This draft stacks on runtime migration PR77 and requires backend PR3519 plus the frontend/mobile cutover. Hold merge/release until the combined clients are qualified on staging; published device-agent contracts are unchanged.
Validation: all 245 CLI tests pass with the required 100% coverage gate, including real localhost callbacks, PKCE binding, issuer substitution, anonymous exchange and preservation of existing credentials. Package/native build CI and real staging sessions remain required.