Repository navigation
fix(secrets): keep the stop reason when macOS reports EPERM on kill - #49
Merged
Merged
Conversation
When output exceeded the limit, `stop('OUTPUT_LIMIT')` ran once per stdout
chunk. The second call signalled the process group after its leader had
exited but before it was reaped; macOS returns EPERM there (Linux returns
ESRCH), and `kill` overwrote the failure with EXECUTOR_FAILED. Receipts on
macOS therefore reported the wrong code, and the finish-time SIGKILL could
do the same on a successful run.
- Signal the group only once per stop request.
- Treat EPERM as "already gone" once a stop was requested or the child
closed.
- Never overwrite an earlier failure code (`??=`).
Add a deterministic regression test that makes later group signals throw
EPERM. The executor lifecycle tests only run on macOS, so CI (ubuntu)
does not exercise this path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS, a secret action that hit its output limit returned
EXECUTOR_FAILEDinstead ofOUTPUT_LIMIT.The sequence:
stop()runs once per stdout chunk, so it can be called more than once.EPERM, where Linux returnsESRCH.kill()treats any error other thanESRCHasEXECUTOR_FAILED, and it overwrote the code already set.The
kill('SIGKILL')infinish()could hit the same race, so a successful run could also be reported as failed.Fix (
src/secrets/run.ts):EPERMas "already gone" once a stop was requested or the child closed.??=).Test plan
EPERM, and the receipt must keepOUTPUT_LIMIT. It fails without the fix (EXECUTOR_FAILED) and passes with it.npm run checkpasses locally on macOS: 189 files, 1760 tests.The executor lifecycle tests are skipped on non-macOS, so CI on ubuntu does not exercise this path.