simd: fix MSVC ARM64 build with SJPEG_NEON16_OP/8_OP - #211
Merged
Merged
Conversation
skal65535
commented
Sep 28, 2026
Collaborator
- MSVC aliases all NEONxx_t types to one __n128/__n64 union
- => duplicate operator overloads, C2535
- skip extra conversions for MSVC (not clang-cl, distinct types there)
* MSVC aliases all NEONxx_t types to one __n128/__n64 union * => duplicate operator overloads, C2535 * skip extra conversions for MSVC (not clang-cl, distinct types there)
jzern
approved these changes
Sep 28, 2026
Contributor
|
Let me verify this before submitting. |
Contributor
|
Closer, now the same thing for |
Contributor
Updating that to match passes. Note I also have the following addition to enable NEON. Noticed the failure when I was getting ready to push the patch. |
Contributor
|
|
Collaborator
Author
|
LGTM |
+ enable NEON for MSVC arm targets
jzern
force-pushed
the
skal/fix-neon16-op-msvc
branch
from
September 30, 2026 18:50
0cb739a to
c291d96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.