Repository navigation
Enforce validation when creating an MLOperandDescriptor - #955
Merged
Merged
Conversation
huningxin
reviewed
Sep 11, 2026
shiyi9801
changed the title
Member
|
@shiyi9801 just confirming the shape of this PR is fine and is covered by the existing resolution. After the PR review comments are addressed, this can be merged. Thank you for your contributions that make the API more secure. |
github-actions Bot
added a commit
that referenced
this pull request
Oct 8, 2026
SHA: d9a9a1b Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #949
This PR makes
create an MLOperandDescriptorvalidate the resulting shape via checking dimensions, so oversized outputs are rejected during graph building.concat(),reshape(),pad(), and the pooling ops are restructured to construct their descriptor from the final computed shape instead of mutating one created earlier.This PR also adds unconditional validation for the full-sequence output of
gru()/lstm(), which some platforms produce regardless of thereturnSequenceflag.Preview | Diff