Repository navigation
fix(iterator): keep exhausted object iterators from fetching again - #2224
Merged
Merged
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Contributor
Author
|
I have read the Weaviate Contributor License Agreement and agree to its terms. |
dirkkul
approved these changes
Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The synchronous and asynchronous object iterators do not remember reaching an empty page. After
next()/__anext__()signals exhaustion, another call sends another fetch request and can even yield newly added objects. Python's iterator protocol requires subsequentnext()calls to keep raisingStopIteration.Remember exhaustion for the current traversal in both iterators. Explicit
iter()/__aiter__()still resets the iterator and its initialaftercursor, preserving the existing restart behavior.Testing
python -m pytest test --ignore=test/test_timeout.py -q: 543 passed, 1 skipped.Three tests in
test/test_timeout.pyfail on this Windows/GBK machine while readingconftest.pywithout an explicit encoding; the same three fail on unmodified upstream code. A combined unit/mock run was interrupted when it stopped making progress after the unit failures, so no complete mock-suite pass is claimed. Live Weaviate integration tests were not run.AI assistance: Codex investigated the issue, wrote the patch, tests and PR description, and ran the local checks.