Repository navigation
Fix earthquake source filtering and coordinate normalization - #6
Conversation
|
Warning Review limit reached
More reviews will be available in 10 minutes and 39 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (29)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7490918ebc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,3 @@ | |||
| from .usgs_fdsn import USGSFDSNSource | |||
| class EMSCSource(USGSFDSNSource): | |||
| def __init__(self): super().__init__(); self.name='emsc'; self.display_name='EMSC / SeismicPortal'; self.coverage='Europe/global'; self.attribution='EMSC / SeismicPortal (CC BY 4.0 where applicable)'; self.homepage_url='https://www.seismicportal.eu/'; self.supported_feeds=['latest','day','7day','30day'] | |||
There was a problem hiding this comment.
When users select source=emsc, this class still inherits USGSFDSNSource.fetch() unchanged, so it calls the USGS FDSN URL and rewrites returned rows as source='usgs_fdsn'. The subsequent API query filters for source = 'emsc', leaving EMSC-specific requests empty while source=all misattributes/duplicates USGS data instead of ingesting EMSC events. Override the fetch/normalization path or keep the source disabled until it uses the EMSC endpoint.
Useful? React with 👍 / 👎.
| @@ -1 +1 @@ | |||
| {% extends 'base.html' %}{% block title %}Earthquake Analytics Dashboard{% endblock %}{% block head %}<script src="https://cdn.jsdelivr.net/npm/chart.js"></script>{% endblock %}{% block content %}<section class="hero"><div><h1>Earthquake Monitoring Dashboard</h1><p class="muted">Live USGS feeds with resilient SQLite cache, analytics, and honest probabilistic risk scoring.</p></div><div><a class="btn" href="/map">Open Map</a> <a class="btn" href="/forecast">Experimental Forecast</a></div></section><section class="card controls"><div><label>Feed</label><select id="feed"><option value="day">Past day</option><option value="hour">Past hour</option><option value="7day">Past 7 days</option><option value="30day">Past 30 days</option><option value="significant">Significant</option><option value="m2.5">M2.5+</option><option value="m4.5">M4.5+</option></select></div><div><label>Min magnitude</label><input id="magMin" type="number" value="1" step=".1"></div><div><label>Limit</label><input id="limit" type="number" value="800"></div><button id="apply">Apply</button><button id="refresh">Force refresh</button><button id="export">Export CSV</button><div id="source" class="muted"></div></section><section class="grid"><div class="card kpi"><span>Total events</span><br><b id="total">0</b></div><div class="card kpi"><span>Max magnitude</span><br><b id="maxmag">-</b></div><div class="card kpi"><span>Average magnitude</span><br><b id="avgmag">-</b></div><div class="card kpi"><span>Tsunami flags</span><br><b id="tsunami">0</b></div></section><section class="grid"><div class="card"><h3>Hourly trend</h3><canvas id="trend"></canvas></div><div class="card"><h3>Magnitude distribution</h3><canvas id="magChart"></canvas></div><div class="card"><h3>Depth distribution</h3><canvas id="depthChart"></canvas></div><div class="card warning"><h3>Experimental model forecast</h3><div id="forecastCard">Loading...</div><p class="muted">Not deterministic earthquake prediction.</p></div></section><section class="grid"><div class="card"><h3>Top regions</h3><ul id="regions"></ul></div><div class="card"><h3>Significant events</h3><table class="table"><tbody id="events"></tbody></table></div></section>{% endblock %}{% block scripts %}<script src="{{ url_for('static', filename='js/dashboard.js') }}"></script>{% endblock %} | |||
| {% extends 'base.html' %}{% block title %}Earthquake Analytics Dashboard{% endblock %}{% block head %}<script src="https://cdn.jsdelivr.net/npm/chart.js"></script>{% endblock %}{% block content %}<section class="hero"><div><h1>Earthquake Monitoring Dashboard</h1><p class="muted">Live USGS feeds with resilient SQLite cache, analytics, and honest probabilistic risk scoring.</p></div><div><a class="btn" href="/map">Open Map</a> <a class="btn" href="/forecast">Experimental Forecast</a></div></section><section class="card controls"><div><label>Source</label><select id="source"><option value="all">All enabled sources</option><option value="usgs">USGS GeoJSON</option><option value="usgs_fdsn">USGS FDSN</option><option value="emsc">EMSC</option><option value="isc">ISC</option><option value="geofon">GFZ/GEOFON</option><option value="bmkg">BMKG</option><option value="geonet">GeoNet</option><option value="auspass">AusPass</option></select></div><div><label>Feed</label><select id="feed"><option value="day">Past day</option><option value="hour">Past hour</option><option value="7day">Past 7 days</option><option value="30day">Past 30 days</option><option value="significant">Significant</option><option value="m2.5">M2.5+</option><option value="m4.5">M4.5+</option></select></div><div><label>Min magnitude</label><input id="magMin" type="number" value="1" step=".1"></div><div><label>Limit</label><input id="limit" type="number" value="800"></div><button id="apply">Apply</button><button id="refresh">Force refresh</button><button id="export">Export CSV</button><div id="source" class="muted"></div></section><section class="grid"><div class="card kpi"><span>Total events</span><br><b id="total">0</b></div><div class="card kpi"><span>Max magnitude</span><br><b id="maxmag">-</b></div><div class="card kpi"><span>Average magnitude</span><br><b id="avgmag">-</b></div><div class="card kpi"><span>Tsunami flags</span><br><b id="tsunami">0</b></div></section><section class="grid"><div class="card"><h3>Hourly trend</h3><canvas id="trend"></canvas></div><div class="card"><h3>Magnitude distribution</h3><canvas id="magChart"></canvas></div><div class="card"><h3>Depth distribution</h3><canvas id="depthChart"></canvas></div><div class="card warning"><h3>Experimental model forecast</h3><div id="forecastCard">Loading...</div><p class="muted">Not deterministic earthquake prediction.</p></div></section><section class="grid"><div class="card"><h3>Top regions</h3><ul id="regions"></ul></div><div class="card"><h3>Significant events</h3><table class="table"><tbody id="events"></tbody></table></div></section>{% endblock %}{% block scripts %}<script src="{{ url_for('static', filename='js/dashboard.js') }}"></script>{% endblock %} | |||
There was a problem hiding this comment.
When the dashboard loads, dashboard.js uses document.getElementById('source') both to read the source selector and to write the status text. Because this line now contains both the <select id="source"> and a later <div id="source">, the lookup returns the select, and the first load replaces its options with status text, breaking the source picker and subsequent refreshes. Give the status element a separate id.
Useful? React with 👍 / 👎.
Motivation
Description
app/services/sources/includingnormalizer.py,usgs_geojson.py,usgs_fdsn.py,bmkg.py,geonet.pyand registry/stubs foremsc,isc,geofon,auspass, plusbase.pyandregistry.py.source,raw_source, per-source/feed refresh metadata keys, andis_bootstrap, plusupsert_earthquakes()changes to set source-aware metadata; add antimeridian-safe longitude filtering toquery_earthquakes().[longitude, latitude, depth]) and implementcanonical_event()that validates and normalizeslatitude/longitude, rejecting NaN/infinite/out-of-range values before storage.GET /api/earthquakessupportssource,feed,include_demo, dateline metadata and warnings; addGET /api/sourcesandPOST /api/refresh; propagate source/feed filtering to/api/summary,/api/regions,/api/timeseries, and/api/forecast.Source/Feed, style bootstrap/demo markers differently, and validate/skips bad coordinates before plotting.ENABLE_BOOTSTRAP_DATA=false,ALLOW_BOOTSTRAP_AS_FRESH_CACHE=false,ENABLED_SOURCES,SOURCE_*settings), update.env.example, README, and add lightweight source rate/timeout settings.Testing
GET /api/sourcesand filtered APIs, all exercised bypytest.pytestand received all tests passing (15 passed).python -m compileall .and confirmed the codebase compiles without syntax errors.Codex Task