Repository navigation
Fix runtimes from rounds 214-216 - #531
Merged
Merged
Conversation
- Ship lasers no longer call take_damage() on walls, which have no integrity. - Slime extract Moved() takes the full argument list so shuttle moves don't fail. - Survey console stops logging every tick for overmap objects with no survey category. - Ship saves keep the construction console RCD's airlock electronics, so its UI opens. - Lobby terminal skips winset on a client that is logging out. - Guard nulls in chat hallucinations, chem splashes, storage viewers, HE pipes, eyelid animation and the indebted quirk. - Cat and find-and-set AI pass contents to typecache_filter_list instead of a mob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes runtimes from the live rounds on 2026-11-10 (rounds 214-216).
Changes
take_damage()on walls. Walls have no integrity, so the wall-damage branch only ever errored (~100 per round). Lasers still hit mobs and objects.clear_stockdeleted them and the console's RCD UI hit a null on any ship loaded from a save.Moved()override takes the full argument list, so moving an extract with a shuttle no longer fails with "bad arg name 'momentum_change'".winseton a client that is logging out ("bad client").contentstotypecache_filter_listinstead of a bare mob.Upstream edits are one-liners marked
VOIDCREW EDIT.Compiles with 0 errors. Not playtested.