Add support for web origin private file system (OPFS) - #662
Open
timo-drick wants to merge 7 commits into
Open
timo-drick wants to merge 7 commits into
timo-drick wants to merge 7 commits into
Conversation
…orts temporary files on the web target.
…nc duplicates of write and delete because they where already suspend functions so they can directly supported on web.)
…port file size and last modified time. Can be updated with PlatformFile.update() to refresh metadata.
Add support for web origin private file system (OPFS)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the web origin private file system (OPFS), enabling temporary files on web targets.
The main new feature is FileKit.filesDirectory() function which will work on all platforms including web.
Unfortunately there are some things i am not really pleased with. So to be able to support PlatformFile attributes like size, lastModified ... the current web implementation loads a snapshot of a BrowserFile. It will not automatically return the newest size or lastModified values. To get them we need a suspend function interface. So i am also a little bit unsure how to cleanly add this into the architecture of FileKit. But it would be really nice if the user does not need to care which platform it is and can write most of the code in common part. So in the long run would be nice to have suspension functions for the different attributes of the file maybe for everything.