🐛 Preserve Android document tree parents - #658
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Android, navigating from
Documents/Notes/Draftsback to its parent could returnDocuments, losing the selected tree grant and causinglist()to throwUri is not a directory.Resolve external-storage parents from document IDs while preserving the original tree URI. Stop at the selected root, and exclude that root from child metadata lookup so nested selected directories can be listed correctly. Return
nullfor content URIs whose parent cannot be reliably determined.Updates the PlatformFile guide and API documentation. Adds regression coverage for nested navigation, tree boundaries, encoded names, storage-volume roots, and unsupported content URIs. The sample already handles a null parent.
Related to #655.
Validation
./gradlew :filekit-core:testAndroidHostTest --tests '*PlatformFileParentAndroidTest*' --max-workers=1— 11 passed, including API 23 coverage../gradlew :filekit-core:testAndroidHostTest --tests '*PlatformFileAndroidTest*' --max-workers=1— 23 passed.ktlint-compose-0.4.28-all.jar— passed.git diff --check— passed.The tests use Robolectric with a provider that models a grant to one selected tree. Real-device verification remains outstanding; broader multiplatform checks are left to CI. CI results are pending at PR creation.
Manual verification
On an Android test installation without an existing broader Documents grant:
Documents/Notes/Drafts/note.txt.Documents/NotesusingFileKit.openDirectoryPicker().Drafts, callparent(), and list the result. It should return Notes and list Drafts without throwing.parent()on the selected root; it should returnnull.