Migrate from InstancedMesh2 to BatchedMesh - #1090
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 6837276 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Devin T. Currie (DTCurrie)
approved these changes
Sep 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes our dependency on
InstancedMesh2in favor of using one batched mesh for all geometries. This means spheres, capsules, cylinders, boxes, and even custom buffer geometries are inserted into the same batched mesh.The benefits here are in removing a dependency and much better transparency sorting results. A lot of visibility snapping and clipping issues have been resolved by just putting everything into the same sorting space.
We should also get a (likely very small) performance boost by further reducing draw calls.
A lot of redundant code in each individual instancing file (
Boxes.svelte) was reduced due to the single batched mesh taking in a lot of shared logic.