Repository navigation
Add ruff lint to the test workflow - #31
Open
Nicolas Palpacuer (NickPPC) wants to merge 4 commits into
Open
Nicolas Palpacuer (NickPPC) wants to merge 4 commits into
Nicolas Palpacuer (NickPPC) wants to merge 4 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lists the four enums the motor uses so ruff can check undefined names (F403/F405), and drops a placeholder-less f-string (F541). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
lintjob running ruff check andruff format --checkto the existing Build & Test workflow, which already compiles, imports and builds the binary on every PR and push to main. The existingcheckandbuildjobs are unchanged.Changes
lintjob intest.yml:ruff check+ruff format --checkviaastral-sh/ruff-actionpinned by SHA to v4.1.0, ruff 0.17.0ruff.tomlrestricts lint to pyflakes, pycodestyle errors and import sorting, withline-length = 120(formatting diff 75+/32- vs 153+/44- at the default 88)ruff formatcommit: 3 files, whitespace and quotes onlytime,odriveinutils.py); theOdriveSerialimport inmain.pyis kept with# noqa: F401because it registers the modelfrom odrive.enums import *replaced with the 4 enums used (AxisState,ControlMode,InputMode,ODriveError; checked against the odrive 0.6.10.post0 wheel), plus one placeholder-less f-stringmartha/pr-tests: that branch is the one merged as Add test.yml workflow #25, which addedtest.yml; nothing else is in flightTesting
srcresolves.check,buildandlintjobs on this PR verify the deps still import and the binary still builds after the import changes.🤖 Generated with Claude Code