Repository navigation
Conversation
Follow-up to #702. Before #702 the processor cache keyed plugins by `fn.name`, so `createAnimatePlugin` renamed each `rehypeAnimate` closure to `rehypeAnimate$<n>` to avoid cache collisions. The cache now keys plugins by function identity (`getPluginId`), so each closure already gets its own key. This removes the `instanceId` counter and the `Object.defineProperty` override. The returned plugin object stays the same. Also: - Extends the unreleased `quiet-plugins-render` changeset with a note on the behavior change: plugin functions created during render now produce a new processor on each render. Create them once (module scope or `useMemo`) to keep cache hits. - Adds a patch changeset for this cleanup.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
farnabaz
marked this pull request as ready for review
October 28, 2026 11:10
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #702.
Before #702 the processor cache keyed plugins by
fn.name, socreateAnimatePluginrenamed eachrehypeAnimateclosure torehypeAnimate$<n>to avoid cache collisions. The cache now keys plugins by function identity (getPluginId), so each closure already gets its own key. This removes theinstanceIdcounter and theObject.definePropertyoverride. The returned plugin object stays the same.Also:
quiet-plugins-renderchangeset with a note on the behavior change: plugin functions created during render now produce a new processor on each render. Create them once (module scope oruseMemo) to keep cache hits.