Skip to content

Give each line chunk only the operator that painted it #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bundolee wants to merge 1 commit into from
Closed

Give each line chunk only the operator that painted it #760

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions wcag-validation/src/main/java/org/verapdf/gf/model/factory/chunks/ChunkParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,15 @@ private void processLineChunk(BoundingBox boundingBox, Long mcid, LineChunk line
lineArtContainer.add(mcid, lineChunk, operatorIndex, xObjectName);
if (StaticStorages.getIsIgnoreMCIDs()) {
boundingBox.union(lineChunk.getBoundingBox());
// The line carries only the operator that painted it. The region's
// full list goes once onto the LineArtChunk that processLineArts
// builds, whose box holds the line, and a consumer that needs the
// whole region finds that chunk through this operator and that box.
// Giving every line the full list cost lines x operators objects: one
// chart of 7,500 strokes made 56 million and ran out of heap.
if (StaticContainers.isDataLoader()) {
lineChunk.getStreamInfos().add(new StreamInfo(operatorIndex, xObjectName, null));
}
}
}

Expand Down Expand Up @@ -1161,11 +1170,8 @@ public void processLineArts() {
List<StreamInfo> pending = lineArtContainer.getStreamInfos(null);
List<LineChunk> lineChunks = lineArtContainer.getLineChunks(null);
if (lineChunks != null && !lineChunks.isEmpty()) {
for (LineChunk lineChunk : lineChunks) {
for (StreamInfo info : pending) {
lineChunk.getStreamInfos().add(new StreamInfo(info));
}
}
// Each line already holds its own operator (processLineChunk). The
// region's list is attached to the boxes below only, once per box.
artifacts.addAll(lineChunks);
lineChunks.clear();
}
Expand Down
Loading