Repository navigation
Work around node-libcurl stalls on Node.js 26 and make the job required - #16
Merged
Merged
Conversation
On Node.js 26, node-libcurl sometimes fails to wake the event loop, so a transfer finishes only on libcurl's 1 s fallback timer. The test suite hits this because its servers run in the same process and connections are reused. Setting FORBID_REUSE in tests avoids the delay. File descriptor uploads stall until timeout with no workaround, so that test is skipped on Node.js 26. With both in place the Node.js 26 CI job is required again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FORBID_REUSEin tests on Node.js 26. On Node.js 26, node-libcurl delivers a finished transfer only when another JS callback runs (Node.js 26: 'end' is not delivered until another JS callback runs JCMais/node-libcurl#454). With in-process test servers and a reused connection, that adds about 1 s per request.timeoutand then crash inside node-libcurl.continue-on-errorfrom the Node.js 26 CI job.docs/platform-notes.mdwith the confirmed cause and the upstream issue link.Verification
npm run lint,npm test,npm run build,npm run lint:package,npm run test:packageall pass (124 passing, 57 pending).npm testpasses (125 passing, 56 pending).