Skip to content

Optimize OEM catalog model collection - #28

Merged
cmendesvdl merged 1 commit into
mainfrom
perf/oem-model-list
Nov 4, 2026
Merged

cmendesvdl merged 1 commit into
mainfrom
perf/oem-model-list

Conversation

@cmendesvdl

Copy link
Copy Markdown
Collaborator

Summary

  • replace repeated += array growth in Get-DATOEMModelInfo with List[object].Add()
  • preserve the existing [array] return contract
  • add a regression check that prevents quadratic model collection from returning
  • refresh the module integrity hash

Performance

A Windows PowerShell benchmark adding 5,000 model-shaped objects completed in 185.84 ms with List[object] versus 2,105.45 ms with array += (11.3x faster). The production path can aggregate models from eight OEM catalogs, so this removes repeated full-array copies from shared catalog discovery.

Validation

  • 58 PowerShell files parsed
  • 2 XAML files parsed
  • 10/10 standalone regression harnesses passed
  • 124/124 Pester 6.2.0 tests passed
  • 20/20 integrity manifest entries verified
  • git diff --check passed

Replace repeated PowerShell array appends with a generic list while preserving the public array return contract. Add a regression assertion and refresh the integrity manifest.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@cmendesvdl
cmendesvdl requested a review from vartaxe as a code owner November 1, 2026 16:23
@cmendesvdl
cmendesvdl merged commit b4d07b8 into main Nov 4, 2026
1 check passed
@cmendesvdl
cmendesvdl deleted the perf/oem-model-list branch November 4, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants