Skip to content

test: remove duplicate grid basic-features demo IT - #10388

Open
web-padawan wants to merge 1 commit into
mainfrom
test/remove-grid-basic-features-demo
Open

web-padawan wants to merge 1 commit into
mainfrom
test/remove-grid-basic-features-demo

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Follow-up to #9792

  • Removed GridViewBasicFeaturesPage and GridViewBasicFeaturesIT (route vaadin-grid-it-demo/basic-features), a leftover demo view
    • Its only test typed into a header filter TextField and checked that rows were filtered. GridFilteringIT#gridWithHeaderFilters_headerCellsRenderFilterFields_filteringUpdatesRows already covers this with an in-memory ListDataProvider.
    • The page's joined year headers and footers had no assertions. Joined headers are covered by GridHeaderFooterRowIT and JoinedHeadersIT.

Type of change

  • Tests

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 9, 2026

Copy link
Copy Markdown

@vaadin-review-bot vaadin-review-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nothing to flag — the changes look good.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants