fix(viewer): harden PDF report rendering - #1192
Open
kusonooyasumi wants to merge 1 commit into
Open
Conversation
Contributor
Greptile SummaryThis PR hardens PDF report generation against unsafe external content and malformed metadata.
Confidence Score: 5/5The PR appears safe to merge with no actionable changed-code defects identified. The new parser emits only fixed formatting tags or escaped token content, unsafe characters are normalized before ReportLab processing, and the dependency lock remains stable. Important Files Changed
Reviews (1): Last reviewed commit: "fix(viewer): harden PDF report rendering" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This builds on and credits the root-cause analysis by @apetcu in #1176, while closing the remaining ReportLab trust-boundary paths found during the broader audit.
Fixes #1171.
Verification
uv run pytest tests/test_report_pdf.py tests/test_fenced_code.py tests/test_viewer.py- 73 passeduv run ruff format --check strix/interface/viewer/report_pdf.py tests/test_report_pdf.pyuv run ruff check strix/interface/viewer/report_pdf.py tests/test_report_pdf.pyuv run mypy strix/interface/viewer/report_pdf.py tests/test_report_pdf.pyuv run bandit -r strix/interface/viewer/report_pdf.py -c pyproject.tomluv lock --checkpr-1176-reprorun generated a valid PDFuv run pytest- 1221 passed, 1 unrelated failure intests/test_pricing.py::test_resolves_common_bare_model_namesbecause the live LiteLLM catalog no longer resolvesMiniMax-M3Prepared with AI assistance; reviewed and tested locally.