Repository navigation
ci: Install the monitors from monitors-build releases - #1183
Merged
Merged
Conversation
✅ Deploy Preview for urunc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cmainas
force-pushed
the
ci/use_monitors-build
branch
from
November 3, 2026 14:05
e8e0b14 to
633290b
Compare
cmainas
marked this pull request as ready for review
November 3, 2026 14:26
cmainas
force-pushed
the
ci/use_monitors-build
branch
from
November 3, 2026 19:13
633290b to
aa89540
Compare
ananos
approved these changes
Nov 6, 2026
The e2e tests gathered the monitors from several places: QEMU came from apt, Firecracker, Cloud Hypervisor and hyperlight-unikraft from their upstream releases, virtiofsd from an S3 bucket, and Solo5 was built from source. To resolve that, we created the monitors-build repository, which publishes static builds of all of them, bundled in a single archive per architecture. Therefore, use these archives instead. The workflows set the version of each monitor, now including QEMU and virtiofsd, and a new find-monitors-release action looks up the monitors-build release that bundles these exact versions. The archive extracts to `/opt/urunc`, and the urunc configuration points every monitor there. As a result, the tests now run with a static QEMU v10.1.1 instead of the one Ubuntu provides. Since the archive provides every monitor for both architectures, hyperlight-unikraft is now also installed on arm64, and the Kubernetes test also gets Cloud Hypervisor, hyperlight-unikraft, virtiofsd and, on arm64, QEMU. The packages that only built Solo5 or came with the apt QEMU are no longer installed. The default versions of the monitors were set in vm_test and again in every caller of kind_test. Keep them in the find-monitors-release action instead, so they are set in a single place, and let ci.yml forward any overrides to kind_test as well. Since the action is now part of the e2e environment, a change in it also runs the e2e tests of the pull request. PR: #1183 Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
The monitors-build releases now include hyperlight-unikraft and name their archives after the bundled versions. Update the example to the v0.2.0 release, install the monitors in `/opt/urunc` and add hyperlight-unikraft to the urunc configuration. PR: #1183 Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
github-actions
Bot
force-pushed
the
ci/use_monitors-build
branch
from
November 6, 2026 14:52
aa89540 to
298bcb0
Compare
urunc-bot Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
The e2e tests gathered the monitors from several places: QEMU came from apt, Firecracker, Cloud Hypervisor and hyperlight-unikraft from their upstream releases, virtiofsd from an S3 bucket, and Solo5 was built from source. To resolve that, we created the monitors-build repository, which publishes static builds of all of them, bundled in a single archive per architecture. Therefore, use these archives instead. The workflows set the version of each monitor, now including QEMU and virtiofsd, and a new find-monitors-release action looks up the monitors-build release that bundles these exact versions. The archive extracts to `/opt/urunc`, and the urunc configuration points every monitor there. As a result, the tests now run with a static QEMU v10.1.1 instead of the one Ubuntu provides. Since the archive provides every monitor for both architectures, hyperlight-unikraft is now also installed on arm64, and the Kubernetes test also gets Cloud Hypervisor, hyperlight-unikraft, virtiofsd and, on arm64, QEMU. The packages that only built Solo5 or came with the apt QEMU are no longer installed. The default versions of the monitors were set in vm_test and again in every caller of kind_test. Keep them in the find-monitors-release action instead, so they are set in a single place, and let ci.yml forward any overrides to kind_test as well. Since the action is now part of the e2e environment, a change in it also runs the e2e tests of the pull request. PR: #1183 Signed-off-by: Charalampos Mainas <charalampos.mainas@gmail.com> Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk> Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The e2e tests gathered the monitors from several places: QEMU came from apt, Firecracker, Cloud Hypervisor and hyperlight-unikraft from their upstream releases, virtiofsd from an S3 bucket, and Solo5 was built from source.
To resolve that, we created the monitors-build repository, which publishes static builds of all of them, bundled in a single archive per architecture. Therefore, use these archives instead.
The workflows set the version of each monitor, now including QEMU and virtiofsd, and a new find-monitors-release action looks up the monitors-build release that bundles these versions. The action also keeps the default versions, so they are set in a single place. The archive is verified against its SHA-256 checksum and extracts to /opt/urunc, and the urunc configuration points every monitor there. The Firecracker used for FreeBSD is still downloaded separately, since monitors-build does not provide it.
On pull requests, vm_test runs the tests of the main branch, but GitHub loads the workflow itself from the pull request. Therefore, both e2e workflows fetch the action from the pull request too, so it always matches the workflow that uses it. A change in the action also runs the e2e tests of the pull request.
As a result, the tests run with a static QEMU v10.1.1 instead of the one Ubuntu provides, hyperlight-unikraft is also installed on arm64, and the Kubernetes test also gets Cloud Hypervisor, hyperlight-unikraft, virtiofsd and, on arm64, QEMU.
Finally, update the monitors-build instructions in the docs to the v0.2.0 release, which includes hyperlight-unikraft. Simiarly with the CI, the instructions verify the archive's checksum before they extract it.
Related issues
How was this tested?
In the PR CI.
LLM usage
Opus 5.5
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).