Repository navigation
Conversation
phndiaye
changed the title
phndiaye
changed the title
phndiaye
force-pushed
the
feature/ember-upgrade-4-to-7
branch
from
November 3, 2026 16:07
b49b748 to
524eb22
Compare
phndiaye
changed the title
Bump the ember-source devDependency from ~3.28.8 to ~4.12.4 so the default test run matches the 4.12 runtime used across the campaign (CI's ember-4.12 try scenario already covered it). The ember-lts-3.28 try scenario is kept, and no published peer range changes. Refs CD-369 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the removed `locationType: 'auto'` with `'history'`, which is what AutoLocation already resolved to in supported browsers. The test environment keeps `'none'`. Refs CD-369 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Raw output of `npx ember-cli-update --to 5.12` (addon blueprint 4.12 → 5.12). Conflicted files kept on our side, unchanged: .ember-cli, .github/workflows/ci.yml, .gitignore, .npmignore, .prettierignore, README.md. Not re-added (absent here): .eslintignore, CONTRIBUTING.md, tests/dummy/config/ember-try.js, tests/helpers/index.js. Hand fixes follow in the next commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the 5.12 blueprint, keep what the dummy app needs to run and test on Ember 5.12: ember-source/ember-cli ~5.12, @ember/test-helpers ^3.3.1, ember-qunit 8.1.0, ember-resolver 12.0.1 (exact, as before), ember-auto-import ^2.8.1, ember-cli-babel ^8.2.0 with @babel/core in dependencies (its peer; the devDependency entry is folded into it), @embroider/test-setup ^4, @ember/optional-features ^2.1, qunit ^2.22 and webpack ^5.95.0 (the merge produced an exact 5.95.0). Leave linting as it is on the base branch (ember-template-lint stays ^3.15.0), and don't take the new node engines (published contract), ember-cli-clean-css or the .watchmanconfig change. Against the base branch, no package resolves to a lower version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`</OSS::PowerSelect />` in the power-select integration test fails the 5.12
template compiler ("closing tag must not be self-closing"); 4.12 accepted
it. Use a plain end tag. Test-only, no behaviour change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- drop @types/ember and @types/ember__* (@types/rsvp stays: ember-source's own types import rsvp, which ships none); the lockfile no longer resolves them as glint's optional peers - ember-source/types, and skipLibCheck since ember-intl 6's declarations import DefinitelyTyped-only modules - SafeString from @ember/template, typed owner lookups and test object stubs - setModifierManager is typed now: the managers are cast to ModifierManager, unchanged at runtime (none of them implements updateModifier) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The custom-assertion imports are only used as values, so declaration emit drops them and consumers lose the global Assert augmentations; preserved references keep them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pnpm only runs prepack for git dependencies without a main file, so consumers pinning a commit got no .d.ts files; the script builds them in pnpm's temporary git-preparation directory only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@storybook/ember 6.4.9 relies on the removed Ember global, so every story failed with 'Ember is not defined'. 9.1.21 is the first release whose peer range accepts ember-source >= 4 and still ships the Ember renderer (10.x published without it). Its renderer still reads the Ember global, so it is patched to require @ember/component instead. Also moves the config to ESM and the webpack 5 builder, renames the .stories.mdx docs to .mdx (plain markup instead of Canvas on raw HTML, which also fixes the Table page that failed to parse), uses storybook/actions and @storybook/addon-designs 10, sets the intl locale from an instance initializer rather than during render, and fixes upload-item importing MockUploader from the wrong controller.
Bump ember-source, ember-cli, @ember/test-helpers 5, ember-qunit 9, ember-resolver 13, ember-template-lint 6, ember-auto-import and @embroider/macros. ember-qunit 9 needs explicit loadTests() and setupEmberOnerrorValidation() in the test helper, @types/qunit >= 2.19.14 for the typed test context, and root imports from @ember/test-helpers (the deep dom/* paths are no longer exported). Split the nav-tab empty @tabArray test in two: Ember 6 no longer skips the second render after an unrecoverable render error.
ember-template-lint 6 is ESM-only, so the custom rules in linters/handlebars can no longer require() it.
Mechanical: `constructor(owner: unknown, ...)` becomes `constructor(owner: Owner, ...)` in 68 files. @glimmer/component 2 requires a typed owner and the change also compiles against 1.x.
ember-intl 7 requires it; 6.x accepts it.
MDX 2+ no longer parses GitHub-style tables on its own (Storybook 6.4 used MDX 1, which did), so the tables in our .mdx docs showed up as raw pipes after the 9.1 upgrade. Add remark-gfm through the addon-docs options.
phndiaye
force-pushed
the
feature/ember-upgrade-4-to-7
branch
from
November 6, 2026 13:58
67dac9b to
8903682
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump the ember-source devDependency from ~3.28.8 to ~4.12.4 so the
default test run matches the 4.12 runtime used across the campaign
(CI's ember-4.12 try scenario already covered it). The ember-lts-3.28
try scenario is kept, and no published peer range changes.
Refs CD-369
What are the observable changes?
Good PR checklist