Declare @action methods as arrow functions - #208
Merged
NullVoxPopuli merged 2 commits intoSep 23, 2026
Merged
Conversation
johanrd
changed the title
11 tasks
@action already bound them, but their types said method, so typescript-eslint's unbound-method flags {{column.getValueForRow row}}.
ColumnReordering's columnOrder field reads save before it is initialized, so it now calls it lazily, like read.
johanrd
force-pushed
the
bound-column-methods
branch
from
September 23, 2026 18:57
47f7709 to
d183f6b
Compare
NullVoxPopuli
approved these changes
Sep 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@actionbinds these methods, but their types say "method", so typescript-eslint'sunbound-methodreports every template use, like{{column.getValueForRow row}}or{{on 'click' row.handleClick}}. As arrow functions, the types say they are bound.All 24 in the library are converted. Only
ColumnOrderis exported as a class, and nothing in the library subclasses it.One extra change:
ColumnReordering'scolumnOrderfield readthis.savebeforesavewas initialized (TS2729). It now calls it lazily, likeread.CI fails because of #209, merge that first
Cowritten by Claude