docs: read the column list once per render - #205
Merged
Merged
Conversation
Cowritten by Claude
johanrd
force-pushed
the
docs-columns-for
branch
from
September 23, 2026 13:03
93731cc to
95e8483
Compare
NullVoxPopuli
approved these changes
Sep 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tip next to the example that already does this.
columns.for(table)returns a new array on every call, so reading it once per row is O(rows × columns) per render. The examples read it into a getter; this says why.Secondary to #206, which caches the list and removes the cliff (240 columns, per row: 126.5 → 20.6 ms). Even with that, reading it once is still slightly cheaper, so the tip stands either way. Close whichever you prefer.
Cowritten by Claude