Conversation
No code references Ox: no require "ox", no Ox. constant use anywhere in lib/ or spec/ — the dependency is stale from before the moxml/lutaml-model migration. Its mere presence hijacks moxml's adapter auto-detection (detect_loaded_adapter prefers :ox whenever the Ox constant is defined), forcing every consumer's moxml traffic onto ox whether they chose it or not; ox is additionally a TruffleRuby cext crash hazard (truffleruby/truffleruby#4454). The Gemfile entry goes too: it re-introduces the same autodetect hijack into the development bundle. No replacement needed — nothing calls Ox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the stale
oxdependencyFixes #74 (filed with the full analysis; zero comments since, so here is the one-line PR it offered).
Verification (this PR's evidence, current
main):unitsml.gemspecdeclaresspec.add_dependency "ox"but nothing inlib/orspec/requires or references it — stale from before the moxml/lutaml-model migration.Why removal matters (from #74):
Moxml::Config.detect_loaded_adapterprefers:oxwhenever theOxconstant is defined, so unitsml dragging ox into every consumer's bundle silently forces all moxml traffic in the process onto the ox adapter. ox is additionally a TruffleRuby cext crash hazard under sustained load (oracle/truffleruby#4454), which we hit packaging Metanorma with tebako. Removing the unused dep lets applications pick their XML backend deliberately (leptris via moxml ≥ 0.5, nokogiri, …).Change: gemspec −1 line (the runtime dep),
Gemfile−1 line (the same autodetect hijack in the development bundle — restore if that entry was deliberate adapter coverage). No code change; nothing calls Ox.— filed on behalf of the tebako ecosystem (tebako-ci)