Repository navigation
fix(plugin): make Claude Code install the packages again, and release 1.3.1 - #99
Merged
Merged
Conversation
… so Claude Code installs the packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #86.
Summary
From 1.2.0, Claude Code installed motion-render without its packages, so every command stopped with
ERR_MODULE_NOT_FOUND. This fixes the lock files and releases 1.3.1.package.jsonand the lock file list the same dependencies.package.jsonlistsonnxruntime-node(added in 1.2.0) underoptionalDependenciesonly, but both lock files also listed it under the root'sdependencies.claude plugin listsaid so on 1.2.0 and 1.3.0:The packages it lists were not installed, because its package.json and package-lock.json list different dependencies. npm itself drops that line when it rewrites the lock, sonpm cinever complained.npm install --package-lock-only --ignore-scripts(npm 11.14.1). The only change in each is that one line.tests/package-lock.test.tschecks that each lock's root lists the samedependencies,optionalDependenciesanddevDependenciesas itspackage.json. It failed on the old skill lock before the fix.The two candidates in #86 (a time or size limit from
onnxruntime-node, the sandbox proxy refusing theffmpeg-staticdownload) were not the cause. Claude Code runs the install with--ignore-scripts, soffmpeg-staticdownloads nothing during it; motion-render already fetches the ffmpeg binary itself on first use (scripts/audio.ts).Test plan
make check: 257 tests passCLAUDE_CONFIG_DIRand installedmotion-render@motion-render: the cached copy getsnode_modules(563 MB, withplaywright-coreandonnxruntime-node) in about 8 s,claude plugin listshows no note, and the cachedcli.tsprints its version and usage