Skip to content

fix(plugin): make Claude Code install the packages again, and release 1.3.1 - #99

Merged
umiyosh merged 2 commits into
masterfrom
fix/issue-86-plugin-deps
Nov 17, 2026
Merged

umiyosh merged 2 commits into
masterfrom
fix/issue-86-plugin-deps

Conversation

@umiyosh

@umiyosh umiyosh commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Closes #86.

Summary

From 1.2.0, Claude Code installed motion-render without its packages, so every command stopped with ERR_MODULE_NOT_FOUND. This fixes the lock files and releases 1.3.1.

  • Cause: Claude Code installs a plugin's packages only when package.json and the lock file list the same dependencies. package.json lists onnxruntime-node (added in 1.2.0) under optionalDependencies only, but both lock files also listed it under the root's dependencies. claude plugin list said so on 1.2.0 and 1.3.0: The packages it lists were not installed, because its package.json and package-lock.json list different dependencies. npm itself drops that line when it rewrites the lock, so npm ci never complained.
  • Fix: both lock files rewritten with npm install --package-lock-only --ignore-scripts (npm 11.14.1). The only change in each is that one line.
  • Guard: tests/package-lock.test.ts checks that each lock's root lists the same dependencies, optionalDependencies and devDependencies as its package.json. It failed on the old skill lock before the fix.
  • Release: 1.3.0 → 1.3.1. The manifest pins the version, so without a new version an installed 1.3.0 is "already at the latest version" and keeps its empty install.

The two candidates in #86 (a time or size limit from onnxruntime-node, the sandbox proxy refusing the ffmpeg-static download) were not the cause. Claude Code runs the install with --ignore-scripts, so ffmpeg-static downloads nothing during it; motion-render already fetches the ffmpeg binary itself on first use (scripts/audio.ts).

Test plan

  • make check: 257 tests pass
  • Added this branch as a git marketplace in a throwaway CLAUDE_CONFIG_DIR and installed motion-render@motion-render: the cached copy gets node_modules (563 MB, with playwright-core and onnxruntime-node) in about 8 s, claude plugin list shows no note, and the cached cli.ts prints its version and usage

@umiyosh
umiyosh merged commit ad6187c into master Nov 17, 2026
1 of 2 checks passed
@umiyosh
umiyosh deleted the fix/issue-86-plugin-deps branch November 17, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plugin 1.2.0: dependencies are not installed, so every motion-render command fails with ERR_MODULE_NOT_FOUND

1 participant