Repository navigation
docs(readme): move the rich version from the hero to Usage - #112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The top of both READMEs now shows only what motion-render does, one request, and the demo video. How to ask for a film cut to the beat moves to Usage, under a new subsection ("Films cut to the beat: the rich version" / "音ハメの動画: rich 版").
Moved as is, with no change to the text: the rich request, its paragraph, the comparison table, and the note that the default works like 1.1. The bold lead line is replaced by the subsection heading.
CI fix (#113)
CI failed twice on this PR with every test passing:
[vitest-worker]: Timeout calling "onTaskUpdate". The error came right aftertests/type.test.ts(142.7 s, the longest file). Two of its tests ran thecheckcommand 12 and 6 times in a row withspawnSync, which blocks the worker so it cannot report to vitest.passesChecknow runs the command withspawnand is awaited, as the file'sdifferalready did for ffmpeg.Fixes #113.
Test plan
prettier --check README.md README.ja.mdpassesmake checkpasses locally: 34 files, 282 tests