Repository navigation
feat(kit): add kit/sketch.js, helpers for a film drawn on one canvas - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97. Part of #87.
Summary
New
kit/sketch.jswith the helpers the two canvas films of #87 each wrote by hand. All of them are pure functions of the time:sketch.camerasketch.view/sketch.onScreensketch.beginsketch.papersketch.labelt0and leaves att1sketch.linesketch.ellipse/sketch.boxWhy
Writing the film is now the longest step of a rich run (6:07 in the #87 trial). About a quarter of that page was these helpers. The hand copies also caused rework:
sketch.beginandsketch.labelremove the first.The name is
sketchto keep it apart fromfx.canvas(which returns a 2D context) andfx.camera(which moves a DOM layer).Change
kit/sketch.jsscripts/kit.tssketch.jsinto the kitreferences/html-film.mdTest
tests/sketch.test.ts:sketchdraws the same frame after seeking back, even with aglobalAlphaleft over on purpose. It changes on the cut and passescheckLayoutwith no page warnings.make checkpasses.Not done here: rewriting the #87 trial film with the helpers to measure how much smaller it gets. The next rich run will show that.