Repository navigation
perf(check): skip the layout check of a film that passed and has not changed since - #107
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94. Part of #87.
Summary
check,previewandbuildno longer run the layout check again on a film that passed it and has not changed. They printlayout: ok (unchanged since 01:40:25)instead.Why
Each run of the layout check takes 8–25 s. The #87 trial ran it 13 times. Most of those were
previewruns while fixing sync, andbuildright after a passingpreview.How
film/.layout-okstores a SHA-256 of every file underfilm/. The hash also covers the check's own code (layout.ts,snapshot.js,repeat.ts), so a new version of the check runs again.checkBeforeCapture(used bypreviewandbuild) and thecheckcommand skip it when the record matchesTest
tests/layoutcache.test.ts:checkcommand twice skips the second run, but not a scene-file check.make checkpasses.