Skip to content

feat(narrate): say how far the voice before each drop runs into the bar before it - #104

Merged
umiyosh merged 1 commit into
masterfrom
feat/issue-91-stop-bar
Nov 18, 2026
Merged

umiyosh merged 1 commit into
masterfrom
feat/issue-91-stop-bar

Conversation

@umiyosh

@umiyosh umiyosh commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Fixes #91. Part of #87.

Summary

After the scene table, narrate now prints one line per drop: where the voice of the scene before ends against the bar before the drop. If the voice runs into that bar, the line says how much to cut.

bar before drop "marks" (0:25.16-0:27.10): the voice of "critic" runs 0.13 s into it; if the music stops there, cut about 1 character
bar before drop "this" (0:54.19-0:56.13): the voice of "lanes" ends 0.33 s before it

Why

The rich skill keeps the bar before a drop free of voice when the music stops there. narrate did not report it.

Change

File Change
scripts/beatcli.ts stopBarLines(timing, script). The character count uses the scene's own speaking rate: voiced characters over speech seconds.
scripts/cli.ts narrate prints the lines after the table, for beat-synced films
skills/rich/SKILL.md, step 2 How to read the line

Test

  • tests/beat-flow.test.ts covers the trial's numbers for both an overrun and a voice that ends in time. The tests failed before the change.
  • make check passes.

@umiyosh
umiyosh merged commit 4b4a53e into master Nov 18, 2026
1 check passed
@umiyosh
umiyosh deleted the feat/issue-91-stop-bar branch November 18, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

narrate: report voice that runs into the stop bar before a drop

1 participant