Repository navigation
feat(narrate): say how far the voice before each drop runs into the bar before it - #104
Merged
Merged
Conversation
This was referenced Nov 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #91. Part of #87.
Summary
After the scene table,
narratenow prints one line per drop: where the voice of the scene before ends against the bar before the drop. If the voice runs into that bar, the line says how much to cut.Why
The rich skill keeps the bar before a drop free of voice when the music stops there.
narratedid not report it.start + lead + speechby hand.Change
scripts/beatcli.tsstopBarLines(timing, script). The character count uses the scene's own speaking rate: voiced characters over speech seconds.scripts/cli.tsnarrateprints the lines after the table, for beat-synced filmsskills/rich/SKILL.md, step 2Test
tests/beat-flow.test.tscovers the trial's numbers for both an overrun and a voice that ends in time. The tests failed before the change.make checkpasses.