Skip to content

feat(player): draw the SFX credit on the first scene when the film has sound effects - #103

Merged
umiyosh merged 2 commits into
masterfrom
feat/issue-95-sfx-credit
Nov 18, 2026
Merged

umiyosh merged 2 commits into
masterfrom
feat/issue-95-sfx-credit

Conversation

@umiyosh

@umiyosh umiyosh commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Fixes #95. Part of #87.

Summary

An html film with sound effects now shows the credit SFX: 11.ai in the bottom-right corner of its first scene by itself. Claude no longer has to remember it. "sfxCredit": false in script.json turns it off, for a user on a paid ElevenLabs plan.

Why

Sound effects made without a paid plan must credit 11.ai. The skills asked Claude to add it by hand. In the #87 trial it was forgotten, and adding it and building again cost about 2:30.

Change

File Change
scripts/work.ts New script option sfxCredit (default true; must be true or false)
scripts/kit.ts kit/timing.js gets sfxCredit: true when the script has sound effects and the option is on
kit/player.js With sfxCredit, the player adds a 24 px white-on-dark chip inside the safe area during the first scene. It is marked data-layout-ok, so the layout check takes it as placed on purpose.
SKILL.md (plain and rich), html-film.md The credit is drawn automatically in html films, and turned off with "sfxCredit": false. Claude Motion films still need it added by hand.

Test

  • tests/work.test.ts: the option's default, false, and a wrong type.
  • tests/html-film.test.ts:
    • A film with sound effects shows the credit in its first scene and not in the second, and passes checkLayout.
    • Without sound effects, or with sfxCredit: false, timing.js has no credit.
  • make check passes.

@umiyosh
umiyosh merged commit 6b0f91b into master Nov 18, 2026
1 check passed
@umiyosh
umiyosh deleted the feat/issue-95-sfx-credit branch November 18, 2026 16:09
@umiyosh umiyosh mentioned this pull request Nov 18, 2026
1 of 2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

player: draw the SFX credit automatically when the film has sound effects

1 participant