Repository navigation
docs(rich): change the picture on the hit's own frame, and say so when sync finds it late - #101
Merged
Merged
Conversation
…n sync finds it late
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96. Part of #87.
Summary
The guide now says to make the biggest change of a drop's head or the final hit on the hit's own frame.
syncsays the same when it finds such a change late.Why
In the #87 trial, the final hit was a zoom into a frame, and it took three
previewruns (2:29) to pass:A zoom that scales by ratio changes the picture more with every frame, so its biggest change comes a few frames after the hit.
Change
references/html-film.md, "山場の働き": a new condition. The change lands on the hit's frame; an eased zoom, above all one that scales by ratio, lands later. On a drop's head and the final hit, use a cut or a single step.scripts/sync.ts: when the change is late, the problem line adds that advice. The line starts the same as before.Test
make checkpasses. The message is a plain string appended to an existing problem line. No test matched the old text, so none needed to change.