Repository navigation
fix(kit): load the faces a page uses only on a canvas before the first frame - #100
Merged
Merged
Conversation
This was referenced Nov 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90. Part of #87.
Summary
A film that draws text only on a canvas now has its fonts loaded before the first frame. Before this,
checkcould fail with "the frame changes after seeking back" even though the film draws from the time alone.Cause
The player loaded the optional hand-written face (Klee One) only when an element's computed style used it. A canvas uses no element, so the face was not loaded. The first frame drew in a fallback font, and a frame drawn again after seeking back used the real one. The glyphs to load also came only from
document.body.textContent, which leaves out scripts in<head>.Change
kit/player.js:ctx.font = "600 40px 'Klee One'".Test
tests/html-film.test.ts. The page draws its text only when Klee One is already loaded, and only before 1 s, so the first frame differs from the bare one only if the player loaded the face up front. It failed before the change and passes after.make checkpasses.