Repository navigation
fix(mydspace): keep Workflow tab after approve from view page (#181) - #194
Open
amadulhaxxani wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix matches the existing configuration contract and updates the regression assertion, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Fixes the return navigation after a claimed-task action on the full item View page so users land on “Workflow tasks” rather than “Your submissions.”
Changes:
- Adds
configuration=workflowto the/mydspacenavigation using the existing configuration enum. - Updates the regression test to assert the Workflow tab navigation parameters.
| File | Description |
|---|---|
src/app/item-page/full/full-item-page.component.ts |
Returns users to Workflow tasks after a completed action. |
src/app/item-page/full/full-item-page.component.spec.ts |
Updates the test name and expected navigation parameters. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Approving a workflow item from its View page redirects to "Your submissions" instead of staying on "Workflow tasks".
Steps to reproduce: Workflow tasks tab → claim item → View → Approve.
Analysis
FullItemPageComponent.onWorkflowActionCompletednavigated to/mydspacewith noconfigurationquery param (full-item-page.component.ts:180), soMyDSpaceGuardfell back to the first available configuration, which is alwaysworkspace(my-dspace.guard.ts:44-51,role.service.ts:27,35). The fix passesconfiguration=workflow; the existing unit test infull-item-page.component.spec.tswas updated to match. Approving from the list itself never navigated, so it is unaffected. All claimed-task actions on the View page share this handler and now return to Workflow tasks.Sync verification
N/A — no
.json5files changed.Copilot review