Repository navigation
Don't gitignore project file - #217
Open
composerinteralia wants to merge 1 commit into
Open
composerinteralia wants to merge 1 commit into
composerinteralia wants to merge 1 commit into
Conversation
I assume `gpgme_n.*` was added to ignore compiled files (.so or whatever), but it also has the effect of ignoring a project file: https://github.com/ueno/ruby-gpgme/blob/master/ext/gpgme/gpgme_n.c That ends up causing problems when trying to use a Bundler git source for this gem, because Bundler git sources copy the repo contents into the cache, but the git ignored file won't ever make it into the repository. Here's a semi-realistic reproduction of what we ran into: ``` # Set up project mkdir gpgme-test cd gpgme-test git init echo "vendor/gems" > .gitignore bundle init bundle config set --local path vendor/gems # Add gpgme as a git source gem bundle add gpgme --github=ueno/ruby-gpgme --skip-install bundle cache --no-install git add -A git commit -m "Test" # Simulate a fresh clone rm -rf vendor/gems git clean -fdx bundle install --local bundle exec ruby -rgpgme -e 'puts "hi"' ``` By the time the bundle install happens, gpgme_n.c is gone and you end up with an error: ``` cannot load such file -- gpgme_n (LoadError) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I assume
gpgme_n.*was added to ignore compiled files (.so or whatever), but it also has the effect of ignoring a project file: https://github.com/ueno/ruby-gpgme/blob/master/ext/gpgme/gpgme_n.cThat ends up causing problems when trying to use a Bundler git source for this gem, because Bundler git sources copy the repo contents into the cache, but the gitignored file won't ever make it into the outer git repository. Here's a semi-realistic reproduction of what we ran into:
By the time the bundle install happens, gpgme_n.c is gone and you end up with an error: