Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem/Feature
When a custom
--timestampis valid RFC3339Nano but not in Go's canonical output form (for example2023-01-01T00:00:00.000Zor2023-01-01T00:00:00+00:00), the webhook signature is computed over a reformatted timestamp while theTwitch-Eventsub-Message-Timestampheader carries the original string. Receivers that verify signatures as documented by Twitch reject these events.Description of Changes:
getSignatureHeadernow writes the message id and the timestamp string exactly as sent in the header into the HMAC, instead of parsing and reformatting it.TestForwardEventSignatureUsesTimestampHeader, which forwards events with three non canonical timestamps to a test server and verifies the signature from the received headers and body.Checklist
Fixes #363