Repository navigation
Conversation
Abse2001
force-pushed
the
chore/update-core-symbol-sizing
branch
from
October 17, 2026 16:23
b412199 to
89639a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eval currently bundles core without the custom-symbol fitting and local-viewbox fix. Update to published
@tscircuit/core@^0.0.2171, which includes core#4705, and align props to published^0.0.704. The existing core dependency-sync script confirms that the shared dependency versions match core.Add round-contact integration fixtures for the Node CircuitRunner, built worker, and browser blob worker. They verify legacy sizing, width-only containment, containment in a rectangle, an offset local viewbox with correct port placement, and explicit stretching. The Node tests include schematic snapshots. These tests fail against the previous core and pass with the fix.
Validation: all 13 hosted CI checks pass, including all seven Node test groups, the full five-test browser suite, TypeScript, formatting, test-matrix coverage, worker imports, and packaged-fabricator validation. The full package build and focused integration tests also pass locally with published core 0.0.2171.
This complete PR targets
mainfor review and uses published npm dependencies throughout.