Skip to content

Make the URLs clickable - #1230

Merged
trunk-io[bot] merged 5 commits into
mainfrom
dylan/clickable-links
Oct 21, 2026
Merged

trunk-io[bot] merged 5 commits into
mainfrom
dylan/clickable-links

Conversation

@dfrankland

Copy link
Copy Markdown
Member

Picks up #1224 from @tyler-breisacher-zipline (his commits are kept as-is) so CI runs with the repo's secrets. On the fork, every check that uploads failed on an empty --token.

When the CLI prints links, wrap them in OSC 8 hyperlinks so terminals make them clickable. This covers the per-test ⤷ links and the 🏷️ Upload: link.

  • superconsole moves to a git pin, because hyperlink support isn't released yet. The lockfile churn is superconsole 0.2's termwiz tree dropping out, plus the bumps superconsole 0.3's manifest requires (tokio, bytes, futures, and so on).
  • Test links stay underlined, so viewers that ignore OSC 8 still show them as links.

Supersedes #1224.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@trunk-io

trunk-io Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

😎 Merged successfully - details.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@dfrankland
dfrankland force-pushed the dylan/clickable-links branch from 392dea7 to 2bafeda Compare October 19, 2026 21:35
@trunk-staging-io

trunk-staging-io Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
pending_quarantine_test should be quarantined when run with variant A test marked as pending was expected to fail but unexpectedly passed. Logs ↗︎
variant_quarantine_test should be quarantined when run with variant A test expected the sum of 2 + 2 to be 5, but it was actually 4, indicating a failing assertion. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.09%. Comparing base (dda4670) to head (2bafeda).

Files with missing lines Patch % Lines
display/src/message.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
+ Coverage   83.86%   84.09%   +0.22%     
==========================================
  Files          74       74              
  Lines       17888    17896       +8     
==========================================
+ Hits        15002    15049      +47     
+ Misses       2886     2847      -39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trunk-io

trunk-io Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Static Badge   Static Badge   Static Badge

Failed Test Failure Summary Logs
pending_quarantine_test should be quarantined when run with variant A test marked as pending was expected to fail but unexpectedly passed. Logs ↗︎
variant_quarantine_test should be quarantined when run with variant A test expected the sum of 2 + 2 to be 5, but it was actually 4, indicating a failing assertion. Logs ↗︎

View Full Report ↗︎ ⋅ Docs

@tyler-breisacher-zipline tyler-breisacher-zipline left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@trunk-io
trunk-io Bot merged commit 83ef4c0 into main Oct 21, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants