Repository navigation
ci: run a release through trunk flakytests before promoting it - #1217
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
==========================================
+ Coverage 83.86% 84.06% +0.19%
==========================================
Files 74 74
Lines 17888 17888
==========================================
+ Hits 15002 15037 +35
+ Misses 2886 2851 -35 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
TylerJang27
approved these changes
Oct 6, 2026
dfrankland
marked this pull request as ready for review
October 6, 2026 20:46
|
😎 Merged successfully - details. |
Both `trunk`s customers install, the bash launcher and the new CLI, must run the version pinned with TRUNK_ANALYTICS_CLI_VERSION before it becomes latest. Needs trunk-io/trunk#34317 and trunk-io/trunk2#6728 released. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
dfrankland
force-pushed
the
dylan/promote-check-trunk-flakytests
branch
from
October 7, 2026 04:19
7fd3841 to
d3e6de4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the precondition from this review thread. Before Promote Release marks a version latest, it runs
TRUNK_ANALYTICS_CLI_VERSION=<version> trunk flakytests --versionand requires the output to be that version.It checks both
trunks that customers install:https://trunk.io/releases/trunk, which readsTRUNK_ANALYTICS_CLI_VERSIONfrom launcher 1.3.5 (trunk-io/trunk#34317)https://install.trunk.io, which reads it from CLI 0.0.9 (trunk-io/trunk2#6728)Both releases are live. Each
trunkruns with its own emptyTRUNK_CACHE, so the version is downloaded fresh. The step runs before AWS credentials are set up, so a failure leaves GitHub and S3 untouched.@trunkio/launcheron npm and the Windowstrunk.ps1aren't checked. Neither has ever routedtrunk flakyteststo analytics-cli, so there is nothing there to pin.Testing
I ran the step's
run:block locally, extracted from this branch'spromote_release.ymland run underbash -eo pipefailwithCI=true, against the published launcher 1.3.5 and CLI 0.0.9:VERSION0.16.0(latest)trunks report 0.16.00.15.69.9.9(no such release)::error::launcher could not download or run 9.9.9The new CLI downloaded from
trunk.io/releases/analytics-cli/(published by #1216), without falling back to GitHub. actionlint (with shellcheck) is clean.🤖 Generated with Claude Code