Repository navigation
Conversation
Adds an ACLs page: filter a cluster's ACLs by principal, resource or host, create one ACL per chosen operation, and delete a single ACL after a confirmation. rust-rdkafka 0.39 doesn't wrap librdkafka's ACL admin API, so acl_admin.rs calls it directly, following the existing groups.rs exception to the unsafe lint. The shared request plumbing moves to admin_request.rs. Delete filters repeat every field of the ACL, never ANY/MATCH, so one delete can't remove other ACLs. Pure types and validation live in acls.rs, outside the exception. The dev and e2e brokers now run StandardAuthorizer with ANONYMOUS as a super user, so ACLs can be managed without locking out existing clients. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JJgxwKrEXCgPunVy24RExr
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
The ACLs page had nothing to show on a fresh dev broker, and every local client connects as ANONYMOUS, a super user, so no ACL could ever be seen refusing anything. The seed now creates 30 ACLs covering every resource type, literal and prefixed patterns, wildcards, DENY rules and host restrictions, plus an empty demo.payments topic to produce to. The dev broker gets a SASL/PLAIN listener on localhost:9094 with one login per demo principal, where the ACLs apply. examples/acl-demo logs in as those users with KafkaJS: `bun run kafka:acl-demo` tries 18 actions and exits 1 when the broker disagrees with the ACLs, and one small program per service shows how each would use Kafka. It never commits offsets, so demo-billing keeps its seeded lag. docs/LOCAL_KAFKA.md documents the demo data, listeners, logins and ACLs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JJgxwKrEXCgPunVy24RExr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A new ACLs page (sidebar, ⌘4) to manage a cluster's ACLs:
How
kui_kafka/src/acl_admin.rscallsrd_kafka_DescribeAcls/CreateAcls/DeleteAclsdirectly, following the existinggroups.rsexception to theunsafe_codelint. The exception is now written down indocs/CODE_STANDARDS.md.groups.rsto a sharedadmin_request.rs. It now also explainsSECURITY_DISABLED(a broker without an authorizer) instead of returning librdkafka's raw text.ANY/MATCH, so deleting one row can't remove other ACLs. The integration test checks this: deletingReadleaves itsDescribesibling.acls.rs, outside the unsafe exception and unit-tested. IPC input is validated in Rust (principal format, cluster name, operations that apply to the resource, NUL characters, at most 100 ACLs per request).create_acls/delete_aclsare inCHANGING_COMMANDS, andlist_aclsis classified read-only.Infra
The dev and e2e brokers now run
StandardAuthorizerwithsuper.users=User:ANONYMOUS. Every PLAINTEXT client, the controller included, keeps full access, and ACLs can be created and listed. Runbun run kafka:down && bun run kafka:upto pick this up locally.Tests
bun run lint,bun run test(83 frontend + Rust unit tests) andbunx tsc --noEmitpass.bun run test:e2epasses in Docker: Rust 109 passed, 0 ignored (incl. the newacls_are_created_listed_and_deleted_exactlyagainst a real broker); UI 10/10 spec files.11-acls.e2e.ts: create two ACLs, cancel a delete, delete exactly one, and check that operations are filtered by resource type.08-no-unprompted-changes: browsing ACLs, the ⌘4 shortcut, and filling in then closing the create dialog send no changing command.🤖 Generated with Claude Code
https://claude.ai/code/session_01JJgxwKrEXCgPunVy24RExr