docs: fix TypeScript import for Prompt types - #4844
Conversation
- Gate the 'Use native build server' UI option on isManagedCloud - Gate the enqueueBuild API path on isCloud() condition - Return clear error from API when feature not available - Add .server-changes/ file for server-only user-facing change Resolves triggerdotdev#4835
- Change import from direct type import to namespace import - PromptHandle, PromptIdentifier, PromptVariables are in the prompts namespace, not directly exported from @trigger.dev/sdk - Matches the pattern used throughout the rest of the documentation Resolves triggerdotdev#4812 (the TypeScript compilation issue)
|
|
Hi @MauryaQbit, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughNative build server settings are now disabled on non-managed-cloud instances. The deployment API returns ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Unrelated changes share one PR
The prompt documentation fix ships beside a separate self-hosted deployment feature. Repository policy requires one issue per pull request.
Was this helpful? React with 👍 or 👎 to provide feedback.
| buildSettings, | ||
| vercelIntegrationEnabled: OrgIntegrationRepository.isVercelSupported, | ||
| canManageBuildSettings, | ||
| isManagedCloud, |
There was a problem hiding this comment.
🔍 Dashboard cloud gate remains unwired
The loader returns isManagedCloud, but the page never passes it into BuildSettingsForm. The self-hosted control gate remains incomplete.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Resolves #4812\n\n- Fixes TS2305 errors by using namespace import pattern\n- Changes import type { PromptHandle, PromptIdentifier, PromptVariables } to import type { prompts }\n- Updates type references to use prompts.PromptIdentifier and prompts.PromptVariables\n- Docs-only change\n\nWIP: waiting for maintainer vouch