feat: hide native Git-based deployments in self-hosted instances - #4841
feat: hide native Git-based deployments in self-hosted instances#4841MauryaQbit wants to merge 1 commit into
Conversation
- Gate the 'Use native build server' UI option on isManagedCloud - Gate the enqueueBuild API path on isCloud() condition - Return clear error from API when feature not available - Add .server-changes/ file for server-only user-facing change Resolves triggerdotdev#4835
|
|
Hi @MauryaQbit, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughThe integrations settings loader now returns managed-cloud status. The native build server switch is disabled on self-hosted instances and shows CLI or GitHub Action guidance. The ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
|
||
| const { gitHubApp, buildSettings } = resultOrFail.value; | ||
|
|
||
| const { isManagedCloud } = featuresForRequest(request); |
There was a problem hiding this comment.
🟡 Cloud previews disable native builds
On *.triggerlabs.dev, featuresForRequest returns false while isCloud permits native builds. Managed previews therefore lose a supported build option.
Prompt for agents
Use one authoritative capability check for both the dashboard and DeploymentService. featuresForRequest only recognizes three exact request hosts, while isCloud also recognizes *.triggerlabs.dev through LOGIN_ORIGIN. Update the integrations loader and native-build gate so managed preview instances receive the same availability result, ideally based on actual build-client availability rather than two separate host lists.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Resolves #4835