fix(webapp): move Queues search and pagination above the table - #4834
Merged
Conversation
On the Queues page the "Search queues…" input and the prev/next pagination arrows sat in the top bar, above the metrics panel, even though they only filter the queue table below it. Their position implied they filtered the metrics — made worse by "Period" sitting in the same row, which genuinely does drive the tiles and charts. Move search and pagination into their own bar between the charts and the table (search left, pagination right), and left-align the Period button so the top bar reads as page-wide scope only. This is the same left/right bar the classic, non-metrics Queues view already uses. Adds a `toolbar` prop to `MetricsLayout.Content` so the bar sits flush on the content it scopes, rather than each page re-inventing the chrome.
|
samejr
marked this pull request as ready for review
August 30, 2026 10:05
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
The control placement change is not something a user needs called out in release notes, so it does not warrant an entry.
matt-aitken
approved these changes
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt Aitken, James Ritchie · Slack thread
✅ Checklist
Testing
Ran the webapp locally against Postgres + Redis with the Queue Metrics UI enabled for the org, seeded 38 queues in one Development environment (two pages at 25 per page) and loaded the Queues page in a browser at 1600×1000.
Checked that:
Checks run:
pnpm --filter webapp run lint,pnpm --filter webapp run typecheck,pnpm run knip,oxfmt --check, and the queue-related webapp tests (queueListPagination,queueMetricsMapping,queueSparklineGrid,queueDepthSeries) — all green.Changelog
Before: the "Search queues…" input and the prev/next pagination arrows lived in the toolbar row above the metrics panel, alongside the Period control. Everything above a block reads as controlling that block, so their position implied they filtered the Queued / Running / Allocated / Environment limit tiles and the charts. They never did — they only affect the queue table further down the page. The confusion was sharpest because Period, sitting in the same row, genuinely does drive those tiles and charts, so there was no cue that its neighbours had a different scope.
After: the top bar is page-wide scope only. Period is left-aligned at the start of the row and the Pause environment button stays at the end. Search and pagination move into their own bar placed between the charts and the table — search on the left, pagination on the right — so each control now sits next to the surface it acts on. That costs one extra row of vertical space, which is the right trade for making the scope of each control legible.
How: the queues route stops rendering
QueueFiltersandPaginationControlsinsideMetricsLayout.Filtersand passes them to a newtoolbarprop onMetricsLayout.Contentinstead. The prop bakes the bar chrome (justify-between, top border, page insets) so it sits flush on the content it scopes and pages can't drift on spacing — the same left/right bar the classic, non-metrics Queues view already renders above its table. No loader, query-param or pagination behaviour changed.Screenshots
Verified in a local browser. The new layout, top to bottom:
Period: 1 hrat the far left,Pause Development environment…at the far right.Search queues…at the left, the prev/next arrows at the right, sitting directly on top of the table.💯