Skip to content

Escape: hide TM suggestions first, then leave Search for the previous mode - #4190

Merged
dwaynebailey merged 2 commits into
translate:mainfrom
dwaynebailey:issue-3955-escape-search-tm
Oct 11, 2026
Merged

dwaynebailey merged 2 commits into
translate:mainfrom
dwaynebailey:issue-3955-escape-search-tm

Conversation

@dwaynebailey

Copy link
Copy Markdown
Member

Escape was bound by both Search and the TM suggestions, so one press did both, and leaving Search always went back to All.

  • TM's Escape only takes the key while suggestions are showing.
  • Escape in Search returns to the mode used before searching.

Closes #3955
Closes #1482

🤖 Generated with Claude Code

dwaynebailey and others added 2 commits October 11, 2026 00:36
TM's Escape takes the key only while suggestions are showing, so with
both open one press hides the suggestions and the next leaves Search.

Closes translate#3955

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ModeController remembers the mode it replaced, so Escape goes back to
e.g. Incomplete instead of All.

Closes translate#1482

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dwaynebailey
dwaynebailey added this pull request to the merge queue Oct 11, 2026
Merged via the queue into translate:main with commit 233b72e Oct 11, 2026
50 of 51 checks passed
@dwaynebailey
dwaynebailey deleted the issue-3955-escape-search-tm branch October 11, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search-close and TM-hide both bind bare Escape in separate accel groups RFE: Escape key should return to the previous navigation mode after searching

1 participant