Repository navigation
Conversation
Fixes to complete the first two sub-issues in issue #59
fix SWEET_propConductivity declaration, per issue #59
Adding new classes to support new definitions in AusTraits
published_classes.csv gains BSPO (radial, tangential, transverse plane), SWEET water concentration and shrink, PATO decreased length and polyploid, PATO glaucous, ENVO wax, CHEBI nitrate, PO xylem vessel member, oil gland, growth ring, leaf epidermis and subsidiary cell, GO perforation plate, and TO stomatal process related trait. SWEET_propChemical and SWEET_procPhysical are declared for the two new SWEET modules. The trichome row's identifier was PO_0004510, which PO obsoleted in favour of PO_0000282 -- the URI the row already used. The identifier and the eight hairiness traits that cite it as a keyword now use PO_0000282; the published triples for those traits are unchanged. Also includes pending edits to APD_trait_hierarchy.csv and published_classes.csv. export/ is not regenerated; that happens before release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
published_classes.csv gains CHEBI essential oil, volatile organic compound, glucose, fructose, sucrose, cellulose, terpenoid, monoterpenoid, sesquiterpenoid and 1,8-cineole; PATO autopolyploid, allopolyploidy, flexibility, inflexible, protogynous and protandrous; PO cauline leaf and rhizome; TO leaf number and fruit set trait; NCIT karyotype and number of chromosomes on karyotype; and OMIT apomixis. Three multi-name labels (GO_0019253, PO_0008032, PO_0025117) now use commas rather than semicolons. The file is CRLF throughout again. The previous commit inserted rows with LF endings, and a later save converted the whole file to LF. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add two trait_group categories used in AusTraits traits.yml but missing from APD_trait_hierarchy.csv: - trait_group_0000708 senesced bark mineral and ion content trait (child of bark mineral and ion content trait) - trait_group_0020214 stomatal process related trait (child of gas exchange trait; exactMatch TO:0020095) Descriptions left blank, to be filled in before the next APD release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The tier_* and hierarchy columns of APD_trait_hierarchy.csv had drifted from Parent (the link published as skos:broader) for 40 of 81 groups, and austraits.build reads `hierarchy`. Add `make sync-hierarchy` to rewrite them from Parent, and a `make check` error when they disagree. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Output of `make sync-hierarchy`: 40 groups' paths change, and a tier_5 column holds the three five-level paths. No other column changes, and the built RDF and CSVs are byte-identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts were mostly line endings: a spreadsheet save had made the hierarchy, namespace and published_classes CSVs CRLF with no final newline. They are LF again, as on develop. Content: kept this branch's vocabulary edits and develop's 2.2.0 fixes (seed length row, GO:0009845, dates). Prose IDs in description_encoded and the hierarchy/glossary descriptions use the colon form (ENVO:01000628), per the 2.2.0 decision; keywords keep underscores. The YAML is in the round-trip form. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
make sync-hierarchy wrote CRLF with no final newline regardless of the file; it now keeps whatever the file has (LF on develop). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
senesced bark mineral and ion content trait and stomatal process related trait had no description, so the RDF published "NA"@en. The first follows its senesced leaf/wood siblings; the second uses its exact match TO:0020095's wording. validate_apd() now reports a group with no label or description, as it already did for traits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1,485 published entities (559 traits, 81 groups, 821 categorical values, 24 glossary terms), 16,877 rendered table rows, and the entity-table digest, all moved by this branch's vocabulary edits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
published_classes.csv gains EnvThes growing season; FLOPO corolla lobe; GO dormancy process; NCIT appendage and pistil; NCBITaxon Formicidae; PATO 2-D shape; PO bracteole, extrafloral nectary, hypanthium, involucre, stipule and leaf lamina intramarginal vein; and TO leaf lamina color distribution. TO_0000852 (fruit set trait), PO_0004542 (rhizome) and PO_0000013 (cauline leaf) had the ontology's comment as their description; they now carry the ontology's definition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The two new monthly_presence traits (active_growing_time, dormancy_time) are categorical with no allowable values, which made the trait-table builder warn. Guard on the row count rather than extending the hard-coded list of month traits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in everything in austraits.build config/traits.yml (develop, 2026-11-15): 192 new traits with URIs, dates, constraints, TO, TRY and BIEN matches; edits to 167 existing traits; 730 categorical values added and 8 removed (breaking, listed in NEWS). 46 TO terms are added to published_classes. pollination_system stays published. Three new traits are renamed ahead of austraits.build, and rain is dropped from seed_germination_treatment. Entity counts re-pinned to 2,399. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The release-time import of austraits.build traits.yml into data/, as a repeatable process: a script (fetch-try, prepare, apply, review) and the conventions for URIs, matches, constraints and dates. RELEASING.md and AGENTS.md point to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
21 traits cite the source of their definition in traits.yml. Those citations now reach their APD references field, through six new APD_references.csv rows (IAWA Committee 1989, Fuller 2025, Horsey & Watson 2012, Jordan 2008, Richards 1997, Lloyd & Schoen 1992) and two existing ones (Chittka 1992, 1994). Citation details are from Crossref. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
apply now merges traits.yml citations into each trait's references, matching by DOI or through references_map.csv, and refuses to write while any is unresolved. prepare reports them, and review gets a References sheet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vocabulary work toward the next APD release, and the remaining sub-issues of #59.
Borrowed terms (
published_classes.csv)obo:.APD_namespace_declaration.csvdeclares two prefixes:SWEET_propChemicalandSWEET_procPhysical.develop.Trichome identifier
The trichome row's URI was
PO_0000282, but itsidentifierwasPO_0004510. PO madePO_0004510obsolete and replaced it withPO_0000282.PO_0000282URI.Trait hierarchy
Parent. Thetier_*andhierarchycolumns had drifted fromParentfor 40 of 81 groups.Parentis what the RDF publishes asskos:broader, while austraits.build readshierarchy.make sync-hierarchynow regenerates the path columns fromParent.make checkfails if they disagree again.tier_5column holds the three five-level paths.trait_group_0000708senesced bark mineral and ion content traittrait_group_0020214stomatal process related trait, which is an exact match for TO:0020095validate_apd()now reports a group with no label or description. These two groups would otherwise have published"NA"@en.Other
data/editsresprouts_after_non-fire_stem_lossandkilled_by_non_fire_disturbance.NCIT_C61427tags were corrected toNCIT:C61427.Checks
make checkpasses: 1,610 tests, no failures.export/is not regenerated. That happens before release.🤖 Generated with Claude Code