Repository navigation
Add monthly presence and text value types - #75
Conversation
The four phenology traits record a Y or N per month, and were typed categorical with no allowable values, which gave austraits.build an empty list of allowed values. They are now typed month presence (glossary_40126), and text (glossary_40128) is added for open-ended values. Both are glossary terms: no published vocabulary has either. APD_VALUE_TYPES (R/build.R) maps each type to its traits.build kind. The site states a month-presence trait's format, and make check fails a trait whose fields disagree with its type. Refs traitecoevo/traits.build#87 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Generated by make data from the previous commit. 27,510 -> 27,526 statements: seven for each new glossary term, and the glossary's hasTopConcept for both. The four phenology traits' ets:valueType now names glossary_40126, and their trait_type in APD_traits.csv reads "month presence [glossary_40126]". APD_categorical_values.csv is unchanged. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Working detail for this PR. Companion PRs: traitecoevo/traits.build#306 (adds the Merge and release orderThis PR and traits.build#306 can merge in either order. austraits.build#884 goes last: it needs an APD release carrying these terms, because its generator reads APD's published release ( Design: the two value types are glossary terms
A trait's The glossary is where APD already keeps the terms it defines itself, so using it needed no new machinery:
Rejected:
What consumers see. In Every place APD branches on type
Golden / export changes (every line read)The artefacts are in their own commit, per CONTRIBUTING. Statements go from 27,510 to 27,526.
Checks
I regenerated austraits.build's Version and NEWSNo version bump here: NEWS gets an Judgement calls to confirm
|
Review on traitecoevo/traits.build#306: "monthly presence" reads as an adjective modifying "presence", and "free text" is the standard term for uncontrolled text. The text definition (glossary_40128) takes the wording agreed for the traits.build schema. glossary_40126 keeps its identifier; only its label changes. Refs traitecoevo/traits.build#87 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Generated by make data from the previous commit. Same 27,526 statements: glossary_40126's prefLabel, glossary_40128's description and definition, and the four phenology traits' trait_type in APD_traits.csv, which now reads "monthly presence [glossary_40126]". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follows traitecoevo/traits.build#306, which renames the trait type in review, and traitecoevo/APD#75, which relabels glossary_40126 "monthly presence". The dictionary also calls text values free text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review on traitecoevo/traits.build#306: text has a definition in a core ontology, so the APD should point at it rather than mint glossary_40128. NCIT_C25704 "Text" is added to published_classes.csv in its obo form, as the APD's other NCIT terms are, and glossary_40128 is removed. It was never released. Monthly presence stays a glossary term. APD_VALUE_TYPES maps NCIT_C25704 to text, and the tests that counted 26 glossary terms now count 25. A text trait's trait_type in APD_traits.csv would read "text [NCIT_C25704]". Refs traitecoevo/traits.build#87 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Generated by make data from the previous commit. 27,526 -> 27,520 statements: glossary_40128's seven and the glossary's hasTopConcept for it go, and NCIT_C25704 gains a prefLabel and identifier. No trait has type text, so APD_traits.csv is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
traitecoevo/APD#75 now borrows text from the NCI Thesaurus in place of the glossary term glossary_40128. No AusTraits trait is text yet, so config/traits.yml is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review on traitecoevo/traits.build#306: glossary_40126's definition now says a value is a bit string of length 12, written with Y for 1 and N for 0, and recorded as a string (xsd:string), matching the traits.build schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Generated by make data from the previous commit. Only glossary_40126's description and definition change; 27,520 statements. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
APD typed its four twelve-month phenology traits as categorical variables with no allowable values, so austraits.build stripped an empty value list from each by name, and nothing said what their values look like.
They are now typed monthly presence (
glossary_40126), and a second new value type, text, covers free text values such as taxon names. Monthly presence is a glossary term, since no published vocabulary defines it; text is borrowed from the NCI Thesaurus (NCIT_C25704). The site states a monthly-presence trait's format, andmake checkfails a trait whose fields disagree with its type. No trait, value, unit or range changes: fourets:valueTypestatements change, and 27,510 statements become 27,520.Part of traitecoevo/traits.build#87
🤖 Generated with Claude Code