Repository navigation
Conversation
Add an apc-release workflow that downloads the NSL exports, checks them against the latest release (columns, key columns, APC row drop, a smoke-test alignment) and creates a dated release: published if the checks pass, a draft if they need review, nothing if unchanged. Part of #315. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
DetailsWhat it does (the decisions on #315: publish automatically, run quarterly, a ~2% drop flags manual review)
Draft releases are invisible to
Testing
After merging
Open for @ehwenk: does a missing value in a key column belong in "review" (as now) or "fail"? |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The smoke test failed open: if the release files couldn't be loaded, it reported no problems. It now fails, and it also checks two APNI-only names, the aligned name and the taxonomic status. - APNI losing more than 10% of its rows, or more duplicated APC taxonIDs, now needs review. Previously APNI cut to 10% passed. - Missing values count only when they increase, and "unchanged" is checked before "review", so a problem already in the published release no longer gives a new draft every quarter. - The workflow runs monthly and re-enables itself through the API, because GitHub disables scheduled workflows after 60 days without repository activity. It still releases only in Jan, Apr, Jul and Oct. Part of #315. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Pushed 4aa47ff with fixes from a review. I tested each one against the four cached releases (2024-10-11, 2026-03-25, 2026-07-30, 2026-11-15). The checks still return "pass" on all three past transitions. The smoke test passed when it couldn't load the release files. If The smoke test now also checks two names found only in APNI, Hakea paludosa and Viola linifolia. They give the same result in 2024-10-11 and 2026-11-15. For every name it now compares the aligned name, the accepted name and the status, not only the accepted name. There was no check on APNI's size. With APNI cut to 10% of its rows, or APC doubled, the result was "pass". These now need review:
A problem that persisted would have created a draft every quarter. "review" was checked before "unchanged", and the draft never becomes the previous release. Missing values in key columns now count only when there are more than in the previous release, and "unchanged" is checked first. This also answers the open question about missing values: they stay as "review", but are measured against the previous release. The schedule is now monthly, with a step that keeps it enabled. GitHub disables scheduled workflows in a public repo after 60 days without repository activity, and the workflow's own runs don't count, so a quarterly schedule would be switched off by any quiet quarter.
Not changed, for you to decide:
Tests: |
Adds an
apc-releaseworkflow that downloads the NSL exports quarterly, checks them against the latest release, and creates a dated release: published if the checks pass, a draft (and a failed run) if they need review, nothing if unchanged or broken.The checks live in
R/release.R, with tests intest-release.R. Details in the first comment.Part of #315.
🤖 Generated with Claude Code