Repository navigation
docs(feat[header]): Link the port picker to home pages and add six ports - #1103
Merged
Merged
Conversation
why: The picker sent each port to that port's page for the current product, such as /en/ruby/latest/core/, and greyed out ports with no such page. Every port has a home page, so one destination fits every row. what: - Point each port at https://libtmux.org/en/<port>/latest/ - Drop the no-matching-page variants for Kotlin, Scala and F#, which existed only to mark ports without the current product's page
why: libtmux.org lists 22 ports. The picker here stopped at 16 and had no row for Perl, Common Lisp, OCaml, Haskell, Clojure or Erlang. what: - Add Perl to Scripting & web, Common Lisp, OCaml and Haskell to Compiled & native, Clojure to JVM and Erlang to BEAM, with the names, short names and order libtmux.org uses - Vendor their marks beside the others in docs/_static/img/site-header/, copied from libtmux.org's /en/brand/<port>/library/logo.svg - Raise the picker's count to 22 and add the names to the width sizer
why: The picker now lists every libtmux.org port and links each one to its home page; the entry for the bars did not say so. what: - Add one sentence to the libtmux.org top and documentation bars entry
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1103 +/- ##
=======================================
Coverage 82.55% 82.55%
=======================================
Files 31 31
Lines 2769 2769
Branches 518 518
=======================================
Hits 2286 2286
Misses 346 346
Partials 137 137 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libtmux.org port picker in this site's header now links every port to its home page,
https://libtmux.org/en/<port>/latest/, instead of that port's page for the current product (/core/,/mcp/or/workspace/). It also lists all 22 libtmux.org ports. Perl, Common Lisp, OCaml, Haskell, Clojure and Erlang are new, with names, groups and order copied from the live libtmux.org picker and their marks vendored indocs/_static/img/site-header/from libtmux.org's/en/brand/<port>/library/logo.svg.Ports, by group: Scripting & web: Python, Ruby, Lua, Julia, TypeScript, Perl. Compiled & native: Rust, Go, C++, Common Lisp, Swift, OCaml, Haskell. JVM: Java, Kotlin, Scala, Clojure. .NET: C#, F#, PowerShell. BEAM: Erlang, Elixir.
Kotlin, Scala and F# lose their "No matching page" variants, which only existed to mark ports lacking the current product's page. This site's own product (Workspace Manager) stays highlighted in the documentation picker, and the CSS and JS are unchanged. The CHANGES line is a separate commit.
Checked by rendering
site-header.html(withsite-context.html) through Jinja: 22 distinct port homes, every href is/en/<port>/latest/, nocore,mcporworkspacein the picker, every referenced logo exists, and the entries match the live libtmux.org picker field for field. I did not run a Sphinx build.