Skip to content

feat: expose linked TinyBus module entry point - #167

Closed
senamakel wants to merge 5 commits into
tinyhumansai:mainfrom
senamakel:windows-linked-modules
Closed

senamakel wants to merge 5 commits into
tinyhumansai:mainfrom
senamakel:windows-linked-modules

Conversation

@senamakel

@senamakel senamakel commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add opt-in tinymemory-module/static-link using TinyBus module_export_optional_static!, which selects dynamic exports by default and a Rust-addressable module in static builds.
  • Expose tinymemory_module::linked_module() for direct host registration.
  • Pin TinyBus commit 433d9ed and use =0.1.2 registry dependency identities, with local Cargo patches for standalone builds.

Related issue

Depends on tinyhumansai/tinybus#29, which builds on merged #28. Ready condition: #29 is merged, this gitlink is reachable from upstream TinyBus, and CI passes. This PR remains a draft until then.

API or behavior changes

Additive public linked_module() under static-link. The default loadable module path and wire contract are unchanged.

Validation

  • cargo fmt --manifest-path crates/tinymemory-module/Cargo.toml --all -- --check
  • cargo check --manifest-path crates/tinymemory-module/Cargo.toml -p tinymemory-module --offline
  • cargo check --manifest-path crates/tinymemory-module/Cargo.toml -p tinymemory-module --features static-link --offline
  • Full clippy, build, test, and coverage suites have not been rerun on this final commit.

Tests

The two feature builds verify both TinyBus macro expansions and the public root reexport. No runtime behavior changes were added in this package.

Documentation

The feature and root entry point are documented in this PR and by TinyBus #29.

Checklist

  • The change is focused on static module registration.
  • No lint levels were relaxed in this update.
  • No secrets or environment contents are included.

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 3 billable files and costs up to $0.75.

Or wait 58 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a4e759bc-295b-4c8d-b060-71466b5ef543

📥 Commits

Reviewing files that changed from the base of the PR and between 4ccbbae and 879d8bc.

⛔ Files ignored due to path filters (1)
  • crates/tinymemory-module/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • crates/tinymemory-module/Cargo.toml
  • crates/tinymemory-module/src/lib.rs
  • vendor/tinybus

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel marked this pull request as ready for review September 29, 2026 16:01
@tinysweeper

tinysweeper Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Incomplete
Priority: none
Reviewed head: 879d8bcf4f91
Updated: 1790697765 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 1 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 9

Completeness: Incomplete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

  • Unreviewed: tinysweeper/tests

Findings

No active actionable findings.

Pending checks: AgentMemory E2E, CortexDB full simulation

Could not review: crates/tinymemory-module/Cargo.toml, crates/tinymemory-module/src/lib.rs, tinysweeper/description, tinysweeper/e2e, tinysweeper/tests

Before merge

  • Complete the critique review for crates/tinymemory-module/Cargo.toml, crates/tinymemory-module/src/lib.rs.
  • Complete the security review for crates/tinymemory-module/Cargo.toml, crates/tinymemory-module/src/lib.rs.
  • Complete the tests review for tinysweeper/tests.
  • Complete the description review for tinysweeper/description.
  • Wait for AgentMemory E2E, CortexDB full simulation.
  • Complete the e2e review for tinysweeper/e2e.

How this fits together

flowchart LR
  n0["setup_error<br/>changed"]:::changed
  n1["setup"]:::impacted
  n2["ModuleConfig"]:::impacted
  n3["bind_memory_client"]:::impacted
  n4["start_queue_pool"]:::impacted
  n5["start_sync_loops"]:::impacted
  n1 -->|calls| n0
  n1 -->|uses| n2
  n1 -->|calls| n3
  n1 -->|calls| n4
  n1 -->|calls| n5
  n3 -->|uses| n2
  n4 -->|uses| n2
  n5 -->|uses| n2
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: crates/tinymemory-module/Cargo.toml, crates/tinymemory-module/src/lib.rs
  • Lane summary: Reviewed 0 files; 0 findings. 2 files could not be reviewed: crates/tinymemory-module/Cargo.toml, crates/tinymemory-module/src/lib.rs.

security

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: crates/tinymemory-module/Cargo.toml, crates/tinymemory-module/src/lib.rs
  • Lane summary: Reviewed 0 files; 0 findings. 2 files could not be reviewed: crates/tinymemory-module/Cargo.toml, crates/tinymemory-module/src/lib.rs.

tests

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: tinysweeper/tests
  • Lane summary: No reviewer could be consulted.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: tinysweeper/description
  • Lane summary: No reviewer could be consulted.

e2e

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: tinysweeper/e2e
  • Lane summary: No reviewer could be consulted; only the job states below are reported. Waiting on end-to-end jobs: `AgentMemory E2E`, `CortexDB full simulation`.
  • Unresolved questions/checks: AgentMemory E2E, CortexDB full simulation
Evidence and run details
  • Models: ladder/vectors
  • Spend: $0.000002
  • Tokens: 0 input · 0 output · 0 cached · 204 embedding
Head State Pass summary
879d8bcf4f91 incomplete 0 active finding(s), 0 resolved finding(s) (at 1790697765)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/tinymemory-module/Cargo.toml, crates/tinymemory-module/src/lib.rs, tinysweeper/description, tinysweeper/e2e, tinysweeper/tests.

$0.0000 · 0 in / 0 out · 204 embedded · ladder/vectors

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 29, 2026
@senamakel senamakel closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant