Skip to content

fix: include rustfmt and clippy in pinned toolchain - #164

Merged
senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:release-toolchain-components
Sep 24, 2026
Merged

senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:release-toolchain-components

Conversation

@senamakel

Copy link
Copy Markdown
Member

Summary

Install rustfmt and clippy with the pinned Rust 1.96.1 toolchain. The patch release workflow failed at cargo fmt --all -- --check because the minimal profile did not include cargo-fmt, even though a separate stable toolchain action installed formatting tools on another toolchain.

Related issue

None.

API or behavior changes

None.

Validation

Tests

No test code changed.

Documentation

The toolchain declaration is the documentation for required components.

Checklist

  • The change is focused on the release build failure
  • No new #[allow(...)], #[ignore], or relaxed lints
  • No secrets, tokens, or .env contents in the diff or the description

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

Or wait 47 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a9f945b7-10ba-4210-92e6-d95539a6538a

📥 Commits

Reviewing files that changed from the base of the PR and between b57b0ab and 03d44f3.

📒 Files selected for processing (2)
  • crates/tinymemory-module/src/service/mod.rs
  • rust-toolchain.toml

Comment @coderabbitai help to get the list of available commands.

@tinysweeper

tinysweeper Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper completed its review; deterministic results follow.

State: Ready for maintainer review
Priority: medium
Reviewed head: 03d44f30194e
Updated: 1790272074 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 1 Active findings 3
Tests 0 Noted findings 0
Documentation 0 Resolved findings 4
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

Added components field to rust-toolchain.toml to include rustfmt and clippy. In crates/tinymemory-module/src/service/mod.rs, narrowed the clippy allow attribute from including both `clippy::unused_async` and `clippy::unused_async_trait_impl` to only `clippy::unused_async`.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

  • medium · critique · Install the LLVM tools required by coverage checks — The repository's CI installs `llvm-tools-preview` alongside rustfmt and clippy before running `cargo-llvm-cov`. A fresh checkout using this toolchain file still lacks that componen (rust\-toolchain\.toml:4)
  • medium · security · Install llvm-tools-preview for coverage checks — The repository's CI installs and runs `cargo-llvm-cov`, which requires the `llvm-tools-preview` rustup component. Because this toolchain configuration uses an explicit component li (rust\-toolchain\.toml:4)
  • medium · description · Restore necessary clippy allow for unused_async_trait_impl — The function `override_scheduler_gate` is intentionally async only to satisfy the interface macro's trait contract; its body is synchronous. Removing `clippy::unused_async_trait_im (\(pull request description\))

Resolved this pass

  • Install the components required by repository checks
  • Install the components required by repository checks
  • Install the components required by repository checks
  • Install toolchain components required by repository checks

Before merge

None.

Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 2 files; 1 finding. (1 observation(s) grouped into shared inline comments) _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _4 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._
  • Evidence: rust\-toolchain\.toml — Install the LLVM tools required by coverage checks

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 2 files; 1 finding. _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _4 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._
  • Evidence: rust\-toolchain\.toml — Install llvm-tools-preview for coverage checks

tests

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Non-behavioural changes: a clippy allow attribute is narrowed (removing one lint) and toolchain components are added. Neither requires tests. _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _4 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The pull request adds the missing toolchain components (rustfmt, clippy) which fixes the CI failure, but the concurrent change to a clippy allow attribute removes a necessary lint suppression, causing a new CI failure for the `override_scheduler_gate` function. _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _4 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._
  • Evidence: \(pull request description\) — Restore necessary clippy allow for unused_async_trait_impl

e2e

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The pull request adjusts a clippy allow-list entry and installs the `clippy` and `rustfmt` components in the toolchain. Neither change alters any externally observable behaviour — no route, command, flag, persisted format, or message is affected — so no end-to-end test is required. Both CI end-to-end jobs passed, and the change is safe to merge. 2 end-to-end jobs passed on this head. _The code index is behind this pull request (indexed at `45ef4c057669`), so retrieved context may be out of date._ _4 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._
Evidence and run details
  • Models: ladder/vectors, gpt-5.6-luna, deepseek-v4-flash
  • Spend: $0.002763
  • Tokens: 118189 input · 7027 output · 13502 cached · 72 embedding
Head State Pass summary
03d44f30194e ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1790270795)
03d44f30194e ready for maintainer review 3 active finding(s), 4 resolved finding(s) (at 1790272074)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0021 · 96,609 in / 6,656 out · 20,420 cached (21%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 72 embedded
critique:    $0.0009 · 38,881 in / 504 out   · 4,054 cached (10%)  · gpt-5.6-luna
security:    $0.0005 · 24,903 in / 216 out   · 3,566 cached (14%)  · gpt-5.6-luna
tests:       $0.0003 · 13,347 in / 1,990 out · 5,120 cached (38%)  · deepseek-v4-flash
description: $0.0001 · 3,643 in  / 2,016 out · 2,048 cached (56%)  · deepseek-v4-flash
e2e:         $0.0002 · 14,178 in / 812 out   · 5,632 cached (40%)  · deepseek-v4-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Sep 24, 2026
@senamakel
senamakel merged commit 8b2f02d into tinyhumansai:main Sep 24, 2026
30 checks passed

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0028 · 118,189 in / 7,027 out · 13,502 cached (11%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 72 embedded
critique:    $0.0008 · 31,429 in  / 1,065 out · 4,054 cached (13%)  · gpt-5.6-luna, deepseek-v4-flash
security:    $0.0011 · 45,766 in  / 1,122 out · 5,352 cached (12%)  · gpt-5.6-luna
tests:       $0.0003 · 15,797 in  / 540 out   · 1,536 cached (10%)  · deepseek-v4-flash
description: $0.0002 · 6,541 in   / 1,543 out · 1,024 cached (16%)  · deepseek-v4-flash
e2e:         $0.0003 · 16,628 in  / 509 out   · 1,536 cached (9%)   · deepseek-v4-flash

Comment thread rust-toolchain.toml
[toolchain]
channel = "1.96.1"
profile = "minimal"
components = ["rustfmt", "clippy"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

priority medium security confident

Install llvm-tools-preview for coverage checks

The repository's CI installs and runs cargo-llvm-cov, which requires the llvm-tools-preview rustup component. Because this toolchain configuration uses an explicit component list, fresh checkouts will not receive it and coverage jobs can fail with a missing-component error. Add llvm-tools-preview to the list.


Additional critique observation

priority medium confident

Install the LLVM tools required by coverage checks

[RULE] missing-toolchain-components

The repository's CI installs llvm-tools-preview alongside rustfmt and clippy before running cargo-llvm-cov. A fresh checkout using this toolchain file still lacks that component, so coverage commands can fail with a missing-component error. Add llvm-tools-preview to the component list.

Suggested change for this observation (reference only)

components = ["rustfmt", "clippy", "llvm-tools-preview"]

Suggested change for the opening observation

Suggested change
components = ["rustfmt", "clippy"]
components = ["rustfmt", "clippy", "llvm-tools-preview"]

[RULE] missing-toolchain-components ·

@tinysweeper tinysweeper Bot added priority: p2 Soon. Real but survivable — a rough edge, a gap, a thing that will bite later. and removed priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p2 Soon. Real but survivable — a rough edge, a gap, a thing that will bite later.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant