fix: include rustfmt and clippy in pinned toolchain - #164
Conversation
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50. Or wait 47 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Comment |
Tiny Sweeper reviewTiny Sweeper completed its review; deterministic results follow. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedAdded components field to rust-toolchain.toml to include rustfmt and clippy. In crates/tinymemory-module/src/service/mod.rs, narrowed the clippy allow attribute from including both `clippy::unused_async` and `clippy::unused_async_trait_impl` to only `clippy::unused_async`. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. Findings
Resolved this pass
Before mergeNone. Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0021 · 96,609 in / 6,656 out · 20,420 cached (21%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 72 embedded
critique: $0.0009 · 38,881 in / 504 out · 4,054 cached (10%) · gpt-5.6-luna
security: $0.0005 · 24,903 in / 216 out · 3,566 cached (14%) · gpt-5.6-luna
tests: $0.0003 · 13,347 in / 1,990 out · 5,120 cached (38%) · deepseek-v4-flash
description: $0.0001 · 3,643 in / 2,016 out · 2,048 cached (56%) · deepseek-v4-flash
e2e: $0.0002 · 14,178 in / 812 out · 5,632 cached (40%) · deepseek-v4-flash
There was a problem hiding this comment.
tinysweeper found nothing blocking. Approving.
$0.0028 · 118,189 in / 7,027 out · 13,502 cached (11%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 72 embedded
critique: $0.0008 · 31,429 in / 1,065 out · 4,054 cached (13%) · gpt-5.6-luna, deepseek-v4-flash
security: $0.0011 · 45,766 in / 1,122 out · 5,352 cached (12%) · gpt-5.6-luna
tests: $0.0003 · 15,797 in / 540 out · 1,536 cached (10%) · deepseek-v4-flash
description: $0.0002 · 6,541 in / 1,543 out · 1,024 cached (16%) · deepseek-v4-flash
e2e: $0.0003 · 16,628 in / 509 out · 1,536 cached (9%) · deepseek-v4-flash
| [toolchain] | ||
| channel = "1.96.1" | ||
| profile = "minimal" | ||
| components = ["rustfmt", "clippy"] |
There was a problem hiding this comment.
Install llvm-tools-preview for coverage checks
The repository's CI installs and runs cargo-llvm-cov, which requires the llvm-tools-preview rustup component. Because this toolchain configuration uses an explicit component list, fresh checkouts will not receive it and coverage jobs can fail with a missing-component error. Add llvm-tools-preview to the list.
Additional critique observation
Install the LLVM tools required by coverage checks
[RULE] missing-toolchain-components
The repository's CI installs llvm-tools-preview alongside rustfmt and clippy before running cargo-llvm-cov. A fresh checkout using this toolchain file still lacks that component, so coverage commands can fail with a missing-component error. Add llvm-tools-preview to the component list.
Suggested change for this observation (reference only)
components = ["rustfmt", "clippy", "llvm-tools-preview"]
Suggested change for the opening observation
| components = ["rustfmt", "clippy"] | |
| components = ["rustfmt", "clippy", "llvm-tools-preview"] |
[RULE] missing-toolchain-components ·
Summary
Install
rustfmtandclippywith the pinned Rust 1.96.1 toolchain. The patch release workflow failed atcargo fmt --all -- --checkbecause the minimal profile did not includecargo-fmt, even though a separate stable toolchain action installed formatting tools on another toolchain.Related issue
None.
API or behavior changes
None.
Validation
rustup show active-toolchainselected Rust 1.96.1 from this filecargo fmt --all -- --checkpassed locallyTests
No test code changed.
Documentation
The toolchain declaration is the documentation for required components.
Checklist
#[allow(...)],#[ignore], or relaxed lints.envcontents in the diff or the description