Skip to content

fix: build TinyMemory module with TinyInference 0.3 - #161

Merged
senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:tinybus-refresh
Sep 24, 2026
Merged

senamakel merged 2 commits into
tinyhumansai:mainfrom
senamakel:tinybus-refresh

Conversation

@senamakel

@senamakel senamakel commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Summary

Bring TinyMemory's module tests in line with TinyInference 0.3's added response fields, explicitly allow TinyInference's pinned TinyTools git source in cargo-deny, and advance the TinyBus gitlink to the merged stream idle deadline fix (tinyhumansai/tinybus#23). The earlier dependency refresh landed in #160.

Related issue

None.

API or behavior changes

No new public API. The module test fixtures now match the upstream response contract.

Validation

  • cargo test --manifest-path crates/tinymemory-module/Cargo.toml --locked --quiet
  • cargo fmt --all -- --check
  • TinyMemory CI

Tests

The full module workspace suite passed locally, including its bus E2E cases.

Documentation

No documentation change needed for test fixtures and a source allowlist matching TinyInference's own policy.

Checklist

  • The change is focused on getting the updated module release green
  • No new #[allow(...)], #[ignore], or relaxed lints
  • No secrets, tokens, or .env contents in the diff or the description

Summary by CodeRabbit

  • Chores
    • Updated supporting components and project validation settings.
  • Tests
    • Updated test coverage to accommodate additional chat response details.

No changes to user-facing functionality are included.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f9355429-8d6a-4100-a470-d8f32633f33b

📥 Commits

Reviewing files that changed from the base of the PR and between b2a5e3a and 5ba066a.

📒 Files selected for processing (4)
  • crates/tinymemory-module/src/chat_test.rs
  • crates/tinymemory-module/tests/module_e2e.rs
  • deny.toml
  • vendor/tinybus
 __________________________________________________
< Brb...ordering more GPUs. CPUs are so last year. >
 --------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

Comment @coderabbitai help to get the list of available commands.

@senamakel
senamakel merged commit b57b0ab into tinyhumansai:main Sep 24, 2026
22 of 23 checks passed
@tinysweeper

tinysweeper Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 1 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: medium
Reviewed head: 5ba066a996a5
Updated: 1790269815 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 1
Tests 2 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 1 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

  • medium · description · Remove or implement the claimed TinyBus gitlink advancement — The pull request description states: 'advance the TinyBus gitlink to the merged stream idle deadline fix (fix: use stream idle deadline after reply handle arrives tinybus#23)'. However, the diff contains no change to any git (\(pull request description\))

Before merge

None.

How this fits together

flowchart LR
  n0["call"]:::impacted
  n1["assert"]:::impacted
  n2["admit_module"]:::impacted
  n3["proxy"]:::impacted
  n4["..._runs_over_the_bus_and_lands_in_the_store"]:::impacted
  n5["...equest_comes_back_under_its_contract_name"]:::impacted
  n4 -->|calls| n0
  n4 -->|tests| n0
  n4 -->|calls| n1
  n4 -->|calls| n2
  n4 -->|calls| n3
  n5 -->|calls| n0
  n5 -->|tests| n0
  n5 -->|calls| n1
  n5 -->|calls| n2
  n5 -->|calls| n3
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 3 files; 0 findings. _The code index is behind this pull request (indexed at `1142af252a15`), so retrieved context may be out of date._ _4 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reviewed 3 files; 0 findings. _The code index is behind this pull request (indexed at `1142af252a15`), so retrieved context may be out of date._ _4 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change updates test fixtures to match TinyInference 0.3's response fields and adds a git source allowlist for TinyTools. However, the description claims to advance the TinyBus gitlink, which is absent from the diff. Merge only after confirming whether the gitlink update is intended or was omitted. _The code index is behind this pull request (indexed at `1142af252a15`), so retrieved context may be out of date._ _4 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._
  • Evidence: \(pull request description\) — Remove or implement the claimed TinyBus gitlink advancement

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.
Evidence and run details
  • Models: ladder/vectors, gpt-5.6-luna, deepseek-v4-flash
  • Spend: $0.004867
  • Tokens: 196883 input · 7644 output · 15516 cached · 117 embedding
Head State Pass summary
5ba066a996a5 ready for maintainer review 1 active finding(s), 0 resolved finding(s) (at 1790269815)

tinysweeper 0.1.0

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0049 · 196,883 in / 7,644 out · 15,516 cached (8%) · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 117 embedded
critique:    $0.0023 · 94,731 in  / 1,276 out · 8,116 cached (9%)  · gpt-5.6-luna
security:    $0.0023 · 93,423 in  / 987 out   · 5,352 cached (6%)  · gpt-5.6-luna
description: $0.0002 · 6,905 in   / 2,192 out · 2,048 cached (30%) · deepseek-v4-flash

@tinysweeper tinysweeper Bot added the priority: p2 Soon. Real but survivable — a rough edge, a gap, a thing that will bite later. label Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p2 Soon. Real but survivable — a rough edge, a gap, a thing that will bite later.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant