Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tinyhosts/static-linkusing TinyBusmodule_export_optional_static!, which selects dynamic exports by default and a Rust-addressable module in static builds.tinyhosts::linked_module()for direct host registration.433d9edand use=0.1.2registry dependency identities, with local Cargo patches for standalone builds.Related issue
Depends on tinyhumansai/tinybus#29, which builds on merged #28. Ready condition: #29 is merged, this gitlink is reachable from upstream TinyBus, and CI passes. This PR remains a draft until then.
API or behavior changes
Additive public
linked_module()understatic-link. The default loadable module path and wire contract are unchanged.Validation
cargo fmt --manifest-path Cargo.toml --all -- --checkcargo check --manifest-path Cargo.toml -p tinyhosts --offlinecargo check --manifest-path Cargo.toml -p tinyhosts --features static-link --offlineTests
The two feature builds verify both TinyBus macro expansions and the public root reexport. No runtime behavior changes were added in this package.
Documentation
The feature and root entry point are documented in this PR and by TinyBus #29.
Checklist